Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm

Issue 2559693003: [ObjC ARC] Converts ios/chrome/browser/passwords:unit_tests to ARC. (Closed)
Patch Set: Cleanup Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
diff --git a/ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm b/ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
index ea5a861a7ba9154a520b3dbacbe5eceb3fc87467..8afcc2c2b948d5fb97fc45c4d43c5bf4fdc0f4c7 100644
--- a/ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
+++ b/ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
@@ -4,7 +4,6 @@
#include <memory>
-#import "base/mac/scoped_nsobject.h"
#include "base/memory/ptr_util.h"
#include "components/password_manager/core/browser/stub_password_manager_client.h"
#include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
@@ -13,6 +12,10 @@
#import "ios/web/public/test/web_test_with_web_state.h"
#include "testing/gtest/include/gtest/gtest.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
class IncognitoPasswordManagerClient
@@ -42,11 +45,10 @@ class PasswordControllerOffTheRecordTest : public web::WebTestWithWebState {
public:
void SetUp() override {
web::WebTestWithWebState::SetUp();
- password_controller_.reset([[PasswordController alloc]
+ password_controller_ = [[PasswordController alloc]
initWithWebState:&off_the_record_web_state_
passwordsUiDelegate:nil
- client:base::MakeUnique<
- IncognitoPasswordManagerClient>()]);
+ client:base::MakeUnique<IncognitoPasswordManagerClient>()];
}
void TearDown() override {
@@ -56,7 +58,7 @@ class PasswordControllerOffTheRecordTest : public web::WebTestWithWebState {
protected:
OffTheRecordWebState off_the_record_web_state_;
- base::scoped_nsobject<PasswordController> password_controller_;
+ PasswordController* password_controller_;
};
// Check that if the PasswordController is told (by the PasswordManagerClient)

Powered by Google App Engine
This is Rietveld 408576698