Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2559673002: Remove ContextLifecycleObserver from RemotePlayback (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
Michael Lippautz
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserver from RemotePlayback We have made RemotePlayback a ContextLifecycleObserver to make RemotePlayback::hasPendingActivity return false after the context gets destroyed. We can do the same thing by checking executionContext->isContextDestroyed in RemotePlayback::hasPendingActivity. This CL does that and removes ContextLifecycleObserver from RemotePlayback. BUG=610176 Committed: https://crrev.com/ee53c427022b948b552f9c4492d8ff8667e277a9 Cr-Commit-Position: refs/heads/master@{#436900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL I'm sorry -- I know this CL is something you tried to land but ...
4 years ago (2016-12-07 08:00:11 UTC) #2
Michael Lippautz
lgtm, no worries
4 years ago (2016-12-07 08:09:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559673002/1
4 years ago (2016-12-07 08:15:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 09:41:55 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-07 09:47:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee53c427022b948b552f9c4492d8ff8667e277a9
Cr-Commit-Position: refs/heads/master@{#436900}

Powered by Google App Engine
This is Rietveld 408576698