Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc

Issue 2559663002: Support focus highlight in Android window (Closed)
Patch Set: Address comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/arc_service_launcher.cc ('k') | components/arc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
diff --git a/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc b/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
index 552675f6388e5544bad9b091392a1489598deee5..c4aad82e60e232bc59b62c976bd7895430be812a 100644
--- a/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
+++ b/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
@@ -118,6 +118,7 @@ class ArcSettingsServiceImpl
// Send settings that need to be synced only on Android first start to
// Android.
void SyncInitialSettings() const;
+ void SyncFocusHighlightEnabled() const;
void SyncFontSize() const;
void SyncLocale() const;
void SyncProxySettings() const;
@@ -185,16 +186,18 @@ void ArcSettingsServiceImpl::StartObservingSettingsChanges() {
Profile* profile = ProfileManager::GetActiveUserProfile();
registrar_.Init(profile->GetPrefs());
+ // Keep these lines ordered lexicographically.
+ AddPrefToObserve(prefs::kAccessibilityFocusHighlightEnabled);
+ AddPrefToObserve(prefs::kAccessibilitySpokenFeedbackEnabled);
+ AddPrefToObserve(prefs::kAccessibilityVirtualKeyboardEnabled);
+ AddPrefToObserve(prefs::kArcBackupRestoreEnabled);
+ AddPrefToObserve(prefs::kUse24HourClock);
AddPrefToObserve(prefs::kWebKitDefaultFixedFontSize);
AddPrefToObserve(prefs::kWebKitDefaultFontSize);
AddPrefToObserve(prefs::kWebKitMinimumFontSize);
- AddPrefToObserve(prefs::kAccessibilitySpokenFeedbackEnabled);
- AddPrefToObserve(prefs::kUse24HourClock);
- AddPrefToObserve(prefs::kArcBackupRestoreEnabled);
AddPrefToObserve(proxy_config::prefs::kProxy);
AddPrefToObserve(onc::prefs::kDeviceOpenNetworkConfiguration);
AddPrefToObserve(onc::prefs::kOpenNetworkConfiguration);
- AddPrefToObserve(prefs::kAccessibilityVirtualKeyboardEnabled);
reporting_consent_subscription_ = CrosSettings::Get()->AddSettingsObserver(
chromeos::kStatsReportingPref,
@@ -227,6 +230,9 @@ void ArcSettingsServiceImpl::OnArcInitialStart() {
}
void ArcSettingsServiceImpl::SyncRuntimeSettings() const {
+ // Keep these lines ordered lexicographically.
+ SyncAccessibilityVirtualKeyboardEnabled();
+ SyncFocusHighlightEnabled();
SyncFontSize();
SyncLocale();
SyncProxySettings();
@@ -234,7 +240,6 @@ void ArcSettingsServiceImpl::SyncRuntimeSettings() const {
SyncSpokenFeedbackEnabled();
SyncTimeZone();
SyncUse24HourClock();
- SyncAccessibilityVirtualKeyboardEnabled();
const PrefService* const prefs =
ProfileManager::GetActiveUserProfile()->GetPrefs();
@@ -273,7 +278,9 @@ void ArcSettingsServiceImpl::AdapterPoweredChanged(
}
void ArcSettingsServiceImpl::OnPrefChanged(const std::string& pref_name) const {
- if (pref_name == prefs::kAccessibilitySpokenFeedbackEnabled) {
+ if (pref_name == prefs::kAccessibilityFocusHighlightEnabled) {
+ SyncFocusHighlightEnabled();
+ } else if (pref_name == prefs::kAccessibilitySpokenFeedbackEnabled) {
SyncSpokenFeedbackEnabled();
} else if (pref_name == prefs::kWebKitDefaultFixedFontSize ||
pref_name == prefs::kWebKitDefaultFontSize ||
@@ -342,6 +349,12 @@ void ArcSettingsServiceImpl::SendBoolPrefSettingsBroadcast(
SendSettingsBroadcast(action, extras);
}
+void ArcSettingsServiceImpl::SyncFocusHighlightEnabled() const {
+ SendBoolPrefSettingsBroadcast(
+ prefs::kAccessibilityFocusHighlightEnabled,
+ "org.chromium.arc.intent_helper.SET_FOCUS_HIGHLIGHT_ENABLED");
+}
+
void ArcSettingsServiceImpl::SyncSpokenFeedbackEnabled() const {
SendBoolPrefSettingsBroadcast(
prefs::kAccessibilitySpokenFeedbackEnabled,
« no previous file with comments | « chrome/browser/chromeos/arc/arc_service_launcher.cc ('k') | components/arc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698