Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2559643005: Enable blink_perf.*_slimmingpaintinvalidation benchmarks on bots (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
dtu, eyaich1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable blink_perf.*_slimmingpaintinvalidation benchmarks on bots These benchmarks were added in https://codereview.chromium.org/2557483002/. They will live for about 1 month until we enable SlimmingPaintInvalidation by default. The benchmarks are also enabled on fyi perf bots in crrev.com/2562753002. BUG=646176 Committed: https://crrev.com/c58f233d75ac48a52591f05ef9a176a923f2cde0 Cr-Commit-Position: refs/heads/master@{#437410}

Patch Set 1 #

Patch Set 2 : Exclude fyi in favor of crrev.com/2562753002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1760 lines, -0 lines) Patch
M testing/buildbot/chromium.perf.json View 32 chunks +1760 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (16 generated)
Xianzhu
4 years ago (2016-12-08 19:00:12 UTC) #3
eyaich1
lgtm Yes that is non-obvious to a lot of people, working on that. I have ...
4 years ago (2016-12-08 19:09:39 UTC) #4
Xianzhu
On 2016/12/08 19:09:39, eyaich1 wrote: > lgtm > > Yes that is non-obvious to a ...
4 years ago (2016-12-08 19:21:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559643005/20001
4 years ago (2016-12-08 19:21:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/331241)
4 years ago (2016-12-08 20:20:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559643005/20001
4 years ago (2016-12-08 20:23:15 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82649)
4 years ago (2016-12-08 20:52:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559643005/20001
4 years ago (2016-12-08 20:55:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82719)
4 years ago (2016-12-08 21:41:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559643005/20001
4 years ago (2016-12-08 21:46:31 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/285507)
4 years ago (2016-12-08 22:29:40 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559643005/20001
4 years ago (2016-12-08 22:37:54 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 01:31:46 UTC) #28
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c58f233d75ac48a52591f05ef9a176a923f2cde0 Cr-Commit-Position: refs/heads/master@{#437410}
4 years ago (2016-12-09 01:35:03 UTC) #30
Xianzhu
After 3 days, there are still only results on Android (which had been there before ...
4 years ago (2016-12-12 17:35:25 UTC) #31
Xianzhu
4 years ago (2016-12-12 17:38:05 UTC) #32
Message was sent while issue was closed.
On 2016/12/12 17:35:25, Xianzhu wrote:
> After 3 days, there are still only results on Android (which had been there
> before this change) for blink_perf.paint_slimmingpaintinvalidation, though I
can
> see other bots in the bots drop down menu in
> https://chromeperf.appspot.com/report.
> 
> See
>
https://chromeperf.appspot.com/report?sid=1fadd54e06c4b025f2aed88c62317394bf0....
> 
> @eyaich: I have two questions:
> 1. Why are Android bots special? They give results regardless of this CL.
> 2. Where else should I change to get results on other bots?

Never mind. I can see results from other bots now. It seems that I must choose
bots from the drop down list, instead of copy and paste a list of bots.

Powered by Google App Engine
This is Rietveld 408576698