|
|
DescriptionEnable blink_perf.*_slimmingpaintinvalidation benchmarks on bots
These benchmarks were added in https://codereview.chromium.org/2557483002/.
They will live for about 1 month until we enable SlimmingPaintInvalidation
by default.
The benchmarks are also enabled on fyi perf bots in crrev.com/2562753002.
BUG=646176
Committed: https://crrev.com/c58f233d75ac48a52591f05ef9a176a923f2cde0
Cr-Commit-Position: refs/heads/master@{#437410}
Patch Set 1 #Patch Set 2 : Exclude fyi in favor of crrev.com/2562753002 #
Messages
Total messages: 32 (16 generated)
Description was changed from ========== Enable blink_perf.*_slimmingpaintinvalidation benchmarks on bots BUG=646176 ========== to ========== Enable blink_perf.*_slimmingpaintinvalidation benchmarks on bots These benchmarks were added in https://codereview.chromium.org/2557483002/. They will live for about 1 month until we enable SlimmingPaintInvalidation by default. Just noticed that I need to modify the buildbot files to run them on bots. BUG=646176 ==========
wangxianzhu@chromium.org changed reviewers: + dtu@chromium.org, eyaich@chromium.org
lgtm Yes that is non-obvious to a lot of people, working on that. I have a CL in the cq that does this for the fyi (crrev.com/2562753002), but you will still need to add it for the main waterfall.
Description was changed from ========== Enable blink_perf.*_slimmingpaintinvalidation benchmarks on bots These benchmarks were added in https://codereview.chromium.org/2557483002/. They will live for about 1 month until we enable SlimmingPaintInvalidation by default. Just noticed that I need to modify the buildbot files to run them on bots. BUG=646176 ========== to ========== Enable blink_perf.*_slimmingpaintinvalidation benchmarks on bots These benchmarks were added in https://codereview.chromium.org/2557483002/. They will live for about 1 month until we enable SlimmingPaintInvalidation by default. The benchmarks are also enabled on fyi perf bots in crrev.com/2562753002. BUG=646176 ==========
On 2016/12/08 19:09:39, eyaich1 wrote: > lgtm > > Yes that is non-obvious to a lot of people, working on that. I have a CL in the > cq that does this for the fyi (crrev.com/2562753002), but you will still need to > add it for the main waterfall. Excluded fyi from this change.
The CQ bit was checked by wangxianzhu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eyaich@chromium.org Link to the patchset: https://codereview.chromium.org/2559643005/#ps20001 (title: "Exclude fyi in favor of crrev.com/2562753002")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481236627204140, "parent_rev": "8f0048f63d34e170e7e693a7a03b2dc2066e776e", "commit_rev": "bcd63b0c40a4bbc15fa39896025e9c7ac5e98a0a"}
Message was sent while issue was closed.
Description was changed from ========== Enable blink_perf.*_slimmingpaintinvalidation benchmarks on bots These benchmarks were added in https://codereview.chromium.org/2557483002/. They will live for about 1 month until we enable SlimmingPaintInvalidation by default. The benchmarks are also enabled on fyi perf bots in crrev.com/2562753002. BUG=646176 ========== to ========== Enable blink_perf.*_slimmingpaintinvalidation benchmarks on bots These benchmarks were added in https://codereview.chromium.org/2557483002/. They will live for about 1 month until we enable SlimmingPaintInvalidation by default. The benchmarks are also enabled on fyi perf bots in crrev.com/2562753002. BUG=646176 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable blink_perf.*_slimmingpaintinvalidation benchmarks on bots These benchmarks were added in https://codereview.chromium.org/2557483002/. They will live for about 1 month until we enable SlimmingPaintInvalidation by default. The benchmarks are also enabled on fyi perf bots in crrev.com/2562753002. BUG=646176 ========== to ========== Enable blink_perf.*_slimmingpaintinvalidation benchmarks on bots These benchmarks were added in https://codereview.chromium.org/2557483002/. They will live for about 1 month until we enable SlimmingPaintInvalidation by default. The benchmarks are also enabled on fyi perf bots in crrev.com/2562753002. BUG=646176 Committed: https://crrev.com/c58f233d75ac48a52591f05ef9a176a923f2cde0 Cr-Commit-Position: refs/heads/master@{#437410} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c58f233d75ac48a52591f05ef9a176a923f2cde0 Cr-Commit-Position: refs/heads/master@{#437410}
Message was sent while issue was closed.
After 3 days, there are still only results on Android (which had been there before this change) for blink_perf.paint_slimmingpaintinvalidation, though I can see other bots in the bots drop down menu in https://chromeperf.appspot.com/report. See https://chromeperf.appspot.com/report?sid=1fadd54e06c4b025f2aed88c62317394bf0.... @eyaich: I have two questions: 1. Why are Android bots special? They give results regardless of this CL. 2. Where else should I change to get results on other bots?
Message was sent while issue was closed.
On 2016/12/12 17:35:25, Xianzhu wrote: > After 3 days, there are still only results on Android (which had been there > before this change) for blink_perf.paint_slimmingpaintinvalidation, though I can > see other bots in the bots drop down menu in > https://chromeperf.appspot.com/report. > > See > https://chromeperf.appspot.com/report?sid=1fadd54e06c4b025f2aed88c62317394bf0.... > > @eyaich: I have two questions: > 1. Why are Android bots special? They give results regardless of this CL. > 2. Where else should I change to get results on other bots? Never mind. I can see results from other bots now. It seems that I must choose bots from the drop down list, instead of copy and paste a list of bots. |