Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2559643003: Changes api logging for FunctionTemplate_NewWithCache. (Closed)

Created:
4 years ago by nverne
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Changes api logging for FunctionTemplate_NewWithCache. https://codereview.chromium.org/2405213002/ introduced FunctionTemplate::NewWithCache in src/api.cc, but used LOG_API(..., NewWithFastHandler) BUG=667237 Committed: https://crrev.com/5d51583c0c283a9e97ea385a0db9f389d81218aa Cr-Commit-Position: refs/heads/master@{#41604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
nverne
Hi jochen. shans said to add you as the reviewer for this minor change because ...
4 years ago (2016-12-08 04:27:36 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-12-08 12:05:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559643003/1
4 years ago (2016-12-08 22:28:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 22:30:29 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 22:31:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d51583c0c283a9e97ea385a0db9f389d81218aa
Cr-Commit-Position: refs/heads/master@{#41604}

Powered by Google App Engine
This is Rietveld 408576698