Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: components/bookmarks/browser/bookmark_model.cc

Issue 2559633003: Factor out bookmark-specific sorting logic from BookmarkIndex (Closed)
Patch Set: comments, virtual destructor, explicit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_model.cc
diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmarks/browser/bookmark_model.cc
index a538e8d9eb8f9cbed9dae9189308ee789e0ff56f..29fdef54045feeba90b001843f16b77375390247 100644
--- a/components/bookmarks/browser/bookmark_model.cc
+++ b/components/bookmarks/browser/bookmark_model.cc
@@ -25,6 +25,7 @@
#include "components/bookmarks/browser/bookmark_storage.h"
#include "components/bookmarks/browser/bookmark_undo_delegate.h"
#include "components/bookmarks/browser/bookmark_utils.h"
+#include "components/bookmarks/browser/typed_count_sorter.h"
#include "components/favicon_base/favicon_types.h"
#include "grit/components_strings.h"
#include "ui/base/l10n/l10n_util.h"
@@ -1111,9 +1112,11 @@ std::unique_ptr<BookmarkLoadDetails> BookmarkModel::CreateLoadDetails() {
CreatePermanentNode(BookmarkNode::OTHER_NODE);
BookmarkPermanentNode* mobile_node =
CreatePermanentNode(BookmarkNode::MOBILE);
+ std::unique_ptr<TitledUrlNodeSorter> node_sorter =
+ base::MakeUnique<TypedCountSorter>(client_.get());
return std::unique_ptr<BookmarkLoadDetails>(new BookmarkLoadDetails(
bb_node, other_node, mobile_node, client_->GetLoadExtraNodesCallback(),
- new BookmarkIndex(client_.get()), next_node_id_));
+ new BookmarkIndex(std::move(node_sorter)), next_node_id_));
}
void BookmarkModel::SetUndoDelegate(BookmarkUndoDelegate* undo_delegate) {
« no previous file with comments | « components/bookmarks/browser/bookmark_index.cc ('k') | components/bookmarks/browser/titled_url_node_sorter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698