Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: components/bookmarks/browser/bookmark_index.h

Issue 2559633003: Factor out bookmark-specific sorting logic from BookmarkIndex (Closed)
Patch Set: comments, virtual destructor, explicit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/bookmarks/browser/BUILD.gn ('k') | components/bookmarks/browser/bookmark_index.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_ 5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_
6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_ 6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
11 #include <set> 11 #include <set>
12 #include <string> 12 #include <string>
13 #include <vector> 13 #include <vector>
14 14
15 #include "base/macros.h" 15 #include "base/macros.h"
16 #include "base/strings/string16.h" 16 #include "base/strings/string16.h"
17 #include "components/query_parser/query_parser.h" 17 #include "components/query_parser/query_parser.h"
18 18
19 namespace bookmarks { 19 namespace bookmarks {
20 20
21 class BookmarkClient;
22 class TitledUrlNode; 21 class TitledUrlNode;
22 class TitledUrlNodeSorter;
23 struct BookmarkMatch; 23 struct BookmarkMatch;
24 24
25 // BookmarkIndex maintains an index of the titles and URLs of bookmarks for 25 // BookmarkIndex maintains an index of the titles and URLs of bookmarks for
26 // quick look up. BookmarkIndex is owned and maintained by BookmarkModel, you 26 // quick look up. BookmarkIndex is owned and maintained by BookmarkModel, you
27 // shouldn't need to interact directly with BookmarkIndex. 27 // shouldn't need to interact directly with BookmarkIndex.
28 // 28 //
29 // BookmarkIndex maintains the index (index_) as a map of sets. The map (type 29 // BookmarkIndex maintains the index (index_) as a map of sets. The map (type
30 // Index) maps from a lower case string to the set (type NodeSet) of 30 // Index) maps from a lower case string to the set (type NodeSet) of
31 // TitledUrlNodes that contain that string in their title or URL. 31 // TitledUrlNodes that contain that string in their title or URL.
32 class BookmarkIndex { 32 class BookmarkIndex {
33 public: 33 public:
34 BookmarkIndex(BookmarkClient* client); 34 BookmarkIndex(std::unique_ptr<TitledUrlNodeSorter> sorter);
35 ~BookmarkIndex(); 35 ~BookmarkIndex();
36 36
37 // Invoked when a title/URL pair has been added to the model. 37 // Invoked when a title/URL pair has been added to the model.
38 void Add(const TitledUrlNode* node); 38 void Add(const TitledUrlNode* node);
39 39
40 // Invoked when a title/URL pair has been removed from the model. 40 // Invoked when a title/URL pair has been removed from the model.
41 void Remove(const TitledUrlNode* node); 41 void Remove(const TitledUrlNode* node);
42 42
43 // Returns up to |max_count| of matches containing each term from the text 43 // Returns up to |max_count| of matches containing each term from the text
44 // |query| in either the title or the URL. 44 // |query| in either the title or the URL.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 std::vector<base::string16> ExtractQueryWords(const base::string16& query); 77 std::vector<base::string16> ExtractQueryWords(const base::string16& query);
78 78
79 // Adds |node| to |index_|. 79 // Adds |node| to |index_|.
80 void RegisterNode(const base::string16& term, const TitledUrlNode* node); 80 void RegisterNode(const base::string16& term, const TitledUrlNode* node);
81 81
82 // Removes |node| from |index_|. 82 // Removes |node| from |index_|.
83 void UnregisterNode(const base::string16& term, const TitledUrlNode* node); 83 void UnregisterNode(const base::string16& term, const TitledUrlNode* node);
84 84
85 Index index_; 85 Index index_;
86 86
87 BookmarkClient* const client_; 87 std::unique_ptr<TitledUrlNodeSorter> sorter_;
88 88
89 DISALLOW_COPY_AND_ASSIGN(BookmarkIndex); 89 DISALLOW_COPY_AND_ASSIGN(BookmarkIndex);
90 }; 90 };
91 91
92 } // namespace bookmarks 92 } // namespace bookmarks
93 93
94 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_ 94 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_
OLDNEW
« no previous file with comments | « components/bookmarks/browser/BUILD.gn ('k') | components/bookmarks/browser/bookmark_index.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698