Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4270)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 2559573002: Disable UI options that allow new tabs before FRE. (Closed)
Patch Set: Fixed downstream and fixed tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
index 7b1f8a2a88a421793cf790bd4f10dc3835a0cc27..de05f0476f745fadfe1976616501b796222d4ad8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
@@ -15,6 +15,7 @@ import android.webkit.MimeTypeMap;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.firstrun.FirstRunStatus;
import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
import org.chromium.chrome.browser.preferences.datareduction.DataReductionProxyUma;
import org.chromium.chrome.browser.search_engines.TemplateUrlService;
@@ -272,6 +273,16 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
}
}
+ // Hide all items that could spawn additional tabs until FRE has been completed.
+ if (!FirstRunStatus.getFirstRunFlowComplete()) {
+ menu.findItem(R.id.contextmenu_open_image_in_new_tab).setVisible(false);
+ menu.findItem(R.id.contextmenu_open_in_other_window).setVisible(false);
+ menu.findItem(R.id.contextmenu_open_in_new_tab).setVisible(false);
+ menu.findItem(R.id.contextmenu_open_in_incognito_tab).setVisible(false);
+ menu.findItem(R.id.contextmenu_search_by_image).setVisible(false);
+ menu.findItem(R.id.menu_id_open_in_chrome).setVisible(false);
+ }
+
if (mMode == FULLSCREEN_TAB_MODE) {
removeUnsupportedItems(menu, FULLSCREEN_TAB_MODE_WHITELIST);
} else if (mMode == CUSTOM_TAB_MODE) {

Powered by Google App Engine
This is Rietveld 408576698