Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2559553002: Checking in retrolambda into third_party/ (Closed)

Created:
4 years ago by F
Modified:
4 years ago
Reviewers:
xam, palmer, brettw, agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Checking in retrolambda into third_party/ Retrolambda will be used to transform Java 8's bytecode to Java 7's bytecode so that Java 8 features such as lamba expressions can be used on Chrome for Android without switching from javac to Jack. BUG=642600 Committed: https://crrev.com/3353ce430e3f6f1eaa5e16b998d66a5fc915b736 Cr-Commit-Position: refs/heads/master@{#436968}

Patch Set 1 : Update #

Patch Set 2 : Add license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/retrolambda/LICENSE.txt View 1 1 chunk +202 lines, -0 lines 0 comments Download
A third_party/retrolambda/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/retrolambda/README.chromium View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/retrolambda/retrolambda-2.3.0.jar.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
F
Hi Andrew, PTAL. Thanks!
4 years ago (2016-12-06 20:42:52 UTC) #5
agrieve
On 2016/12/06 20:42:52, F wrote: > Hi Andrew, PTAL. Thanks! Looks great! lgtm
4 years ago (2016-12-06 20:58:54 UTC) #7
xam
On 2016/12/06 20:58:54, agrieve wrote: > On 2016/12/06 20:42:52, F wrote: > > Hi Andrew, ...
4 years ago (2016-12-06 23:14:41 UTC) #10
brettw
lgtm
4 years ago (2016-12-06 23:59:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559553002/40001
4 years ago (2016-12-07 01:19:12 UTC) #15
palmer
lgtm
4 years ago (2016-12-07 01:25:31 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/349222)
4 years ago (2016-12-07 03:03:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559553002/40001
4 years ago (2016-12-07 16:01:21 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-07 16:06:36 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-07 16:09:27 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3353ce430e3f6f1eaa5e16b998d66a5fc915b736
Cr-Commit-Position: refs/heads/master@{#436968}

Powered by Google App Engine
This is Rietveld 408576698