Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 255953005: Move Transform tests into gfx_unittests. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move Transform tests into gfx_unittests. They do not require any extra setup, so it is easier and they do not run on mac or ios platforms. BUG=331829 TEST=gfx_unittests --gtest_filter=XForm*:Interpolated* TBR=danakj@chromium.org,ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/gfx/gfx.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/ui_unittests.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tfarina
TBRing...
6 years, 8 months ago (2014-04-25 23:40:24 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-25 23:40:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/255953005/1
6 years, 8 months ago (2014-04-25 23:47:17 UTC) #3
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 8 months ago (2014-04-26 04:31:22 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-26 04:31:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/255953005/1
6 years, 8 months ago (2014-04-26 04:32:58 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 10:25:58 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 8 months ago (2014-04-26 10:25:58 UTC) #8
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-26 13:35:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/255953005/1
6 years, 8 months ago (2014-04-26 13:36:15 UTC) #10
tfarina
The CQ bit was unchecked by tfarina@chromium.org
6 years, 8 months ago (2014-04-26 23:12:20 UTC) #11
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 8 months ago (2014-04-26 23:15:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/255953005/1
6 years, 8 months ago (2014-04-26 23:15:51 UTC) #13
tfarina
6 years, 7 months ago (2014-04-28 06:44:18 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 manually as r266448 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698