Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2559523006: Implement `FutureOr<T>` for dart2js. (Closed)

Created:
4 years ago by floitsch
Modified:
4 years ago
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement `FutureOr<T>` for dart2js. In dart2js, FutureOr<T> should simply be treated as `dynamic`. Fixes #28011 BUG= http://dartbug.com/28011 R=johnniwinther@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/cc2eba8c2a23e1659ed26fcd37f9e114d43259fb

Patch Set 1 #

Patch Set 2 : Update status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
floitsch
Depends on https://codereview.chromium.org/2562703002/ Tests are here: https://codereview.chromium.org/2564563003/ for the tests.
4 years ago (2016-12-08 16:05:35 UTC) #2
Siggi Cherem (dart-lang)
lgtm, thanks Florian!
4 years ago (2016-12-08 18:51:39 UTC) #3
Johnni Winther
lgtm
4 years ago (2016-12-09 09:26:24 UTC) #5
floitsch
4 years ago (2016-12-12 14:21:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cc2eba8c2a23e1659ed26fcd37f9e114d43259fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698