Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2559523002: Send overlay promotion hints from to GLStreamTextureImage. (Closed)
Patch Set: reverted media Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index f5c727b59b771e90241d6f547fb73fc309cbf941..69439af133f317a326bfeccb48f1d62987d64d8a 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -1672,6 +1672,12 @@ class GLES2DecoderImpl : public GLES2Decoder, public ErrorStateClient {
// Wrapper for glLinkProgram
void DoLinkProgram(GLuint program);
+ // Wrapper for glOverlayPromotabilityHintSteramTextureMatrixCHROMIUM
piman 2016/12/06 21:40:56 nit: wrong GL name? glOverlayPromotionHintCHROMIUM
liberato (no reviews please) 2016/12/12 16:44:38 Done.
+ void DoSendOverlayPromotionHintCHROMIUM(GLuint client_id,
+ GLboolean promotion_hint,
+ GLint display_x,
+ GLint display_y);
+
// Wrapper for glReadBuffer
void DoReadBuffer(GLenum src);
@@ -8546,6 +8552,34 @@ void GLES2DecoderImpl::DoLinkProgram(GLuint program_id) {
ExitCommandProcessingEarly();
}
+void GLES2DecoderImpl::DoSendOverlayPromotionHintCHROMIUM(
+ GLuint client_id,
+ GLboolean promotion_hint,
+ GLint display_x,
+ GLint display_y) {
+ if (client_id == 0)
+ return;
+
+ TextureRef* texture_ref = GetTexture(client_id);
+ if (!texture_ref) {
+ LOCAL_SET_GL_ERROR(GL_INVALID_VALUE,
+ "glOverlayPromotionHintStreamTextureMatrix",
piman 2016/12/06 21:40:56 nit: fix gl name
liberato (no reviews please) 2016/12/12 16:44:38 Done.
+ "invalid texture id");
+ return;
+ }
+ GLStreamTextureImage* image =
+ texture_ref->texture()->GetLevelStreamTextureImage(
+ GL_TEXTURE_EXTERNAL_OES, 0);
+ if (!image) {
+ LOCAL_SET_GL_ERROR(GL_INVALID_VALUE,
piman 2016/12/06 21:40:56 nit: make this a GL_INVALID_OPERATION, which is mo
liberato (no reviews please) 2016/12/12 16:44:38 Done.
+ "glOverlayPromotionHintStreamTextureMatrix",
piman 2016/12/06 21:40:56 nit: ditto
liberato (no reviews please) 2016/12/12 16:44:38 Done.
+ "texture has no StreamTextureImage");
+ return;
+ }
+
+ image->NotifyPromotionHint(promotion_hint, display_x, display_y);
+}
+
void GLES2DecoderImpl::DoReadBuffer(GLenum src) {
Framebuffer* framebuffer = GetFramebufferInfoForTarget(GL_READ_FRAMEBUFFER);
if (framebuffer) {

Powered by Google App Engine
This is Rietveld 408576698