gpu/GLES2/extensions/CHROMIUM/CHROMIUM_stream_texture_matrix.txt - Issue 2559523002: Send overlay promotion hints from to GLStreamTextureImage.

Side by Side Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_stream_texture_matrix.txt

Issue 2559523002: Send overlay promotion hints from to GLStreamTextureImage. (Closed)

Patch Set: reverted media Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « components/display_compositor/compositor_overlay_candidate_validator_android.cc ('k') | gpu/GLES2/gl2chromium_autogen.h » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Name	1 Name

2	2

3 CHROMIUM_stream_texture_matrix	3 CHROMIUM_stream_texture_matrix

4	4

5 Name Strings	5 Name Strings

6	6

7 CHROMIUM_stream_texture_matrix	7 CHROMIUM_stream_texture_matrix

8	8

9 Version	9 Version

10	10

11 Last Modifed Date: February 16, 2016	11 Last Modifed Date: February 16, 2016

12	12

13 Dependencies	13 Dependencies

14	14

15 OpenGL ES 2.0 is required.	15 OpenGL ES 2.0 is required.

16	16

17 Overview	17 Overview

18	18

19 Allows clients to set the value of a 4x4 uniform to the current texture	19 Allows clients to set the value of a 4x4 uniform to the current texture

20 matrix of a stream texture.	20 matrix of a stream texture.

21	21

22 Allows shader access to the texture matrix for the current front buffer	22 Allows shader access to the texture matrix for the current front buffer

23 of a stream texture. Intended for use with Android SurfaceTexture, which	23 of a stream texture. Intended for use with Android SurfaceTexture, which

24 doesn't provide the value until the front buffer is latched.	24 doesn't provide the value until the front buffer is latched.

25	25

	26 Also allows hints about whether an image could be promoted to an overlay.

	27

26 New Procedures and Functions	28 New Procedures and Functions

27	29

28 The command	30 The command

29	31

30 void UniformMatrix4fvStreamTextureMatrixCHROMIUM(	32 void UniformMatrix4fvStreamTextureMatrixCHROMIUM(

31 GLintUniformLocation location,	33 GLintUniformLocation location,

32 GLbooleanFalseOnly transpose,	34 GLbooleanFalseOnly transpose,

33 const GLfloat* transform)	35 const GLfloat* transform)

34	36

35 Updates a uniform to match the current stream texture's texture matrix	37 Updates a uniform to match the current stream texture's texture matrix

36 multiplied by transform. The stream texture must be bound to the	38 multiplied by transform. The stream texture must be bound to the

37 GL_TEXTURE_EXTERNAL_OES target on the active texture unit.	39 GL_TEXTURE_EXTERNAL_OES target on the active texture unit.

38	40

39 If the bound texture is not a stream texture, then the identity matrix is	41 If the bound texture is not a stream texture, then the identity matrix is

40 used instead.	42 used instead.

41	43

42 <location> Specifies the 4x4f uniform location to be modified.	44 <location> Specifies the 4x4f uniform location to be modified.

43 <transpose> Specifies whether the matrix should be transposed.	45 <transpose> Specifies whether the matrix should be transposed.

44 <transform> Provides an additional transform matrix that is applied	46 <transform> Provides an additional transform matrix that is applied

45 prior to the the stream texture transformation matrix.	47 prior to the the stream texture transformation matrix.

46	48

	49 The command

	50

	51 void SendOverlayPromotionHintCHROMIUM(
	piman 2016/12/06 21:40:56 naming nit: no "Send". The naming logic is that yo naming nit: no "Send". The naming logic is that you're setting state, and the gl names just contain the name of the state you set, not any of "Set" "Send" etc. See e.g. above, UniformMatrix4fvStreamTextureMatrixCHROMIUM "sets" a uniform matrix, but we leave "set" out of the name. liberato (no reviews please) 2016/12/12 16:44:38 Done. Show quoted text On 2016/12/06 21:40:56, piman - On leave - No reviews wrote: > naming nit: no "Send". The naming logic is that you're setting state, and the gl > names just contain the name of the state you set, not any of "Set" "Send" etc. > See e.g. above, UniformMatrix4fvStreamTextureMatrixCHROMIUM "sets" a uniform > matrix, but we leave "set" out of the name. Done.
	52 GLuint texture,

	53 GLboolean promotion_hint,

	54 GLint display_x,

	55 GLint display_y)

	56

	57 Sends a hint about whether the GLImage bound to texture could be promoted

	58 to an overlay or not.

	59

	60 <texture> is the texture id, which should have a stream texture image bound

	61 to it.

	62 <promotion_hint> indicates whether the GLImage could be promoted.

	63 <display_x> is the x coordinate of the origin of the overlay if the image

	64 could be promoted. Otherwise, it is 0.

	65 <display_y> is the y coordinate of the origin of the overlay if the image

	66 could be promoted. Otherwise, it is 0.

	67

	68

	69 If <texture> is not a valid texture, or if it doesn't have a stream texture

	70 image bound to it, then no action is taken.

	71

47 Errors	72 Errors

48	73

49 None.	74 None.

50	75

51 New State	76 New State

52	77

53 None.	78 None.

54	79

55 Revision History	80 Revision History

56	81

57 02/16/2016 Documented the extension	82 02/16/2016 Documented the extension

58 03/21/2016 Amended the interpretation of the matrix argument.	83 03/21/2016 Amended the interpretation of the matrix argument.

OLD	NEW