mash: Have chrome set itself as the wallpaper picker.

mash: Have chrome set itself as the wallpaper picker.

Rename WallpaperManager interface to WallpaperPicker.
Add WallpaperController::SetWallpaperPicker.

Chrome's WallpaperManager registers itself as picker on startup.
Ash's WallpaperController caches a ptr to the picker interface.
WallpaperManager interface no longer provided by Chrome.

Nix unused SetWallpaperImage return value.

BUG=670801
TEST=No wallpaper regressions in Classic ash or Mash.
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,

Committed: https://crrev.com/6e6bcece082c7a57af4a436fe7599770543140a2
Cr-Commit-Position: refs/heads/master@{#437116}

[msw, 2016-12-07 18:11:15]

Description was changed from

==========
mash: Have chrome set itself as the wallpaper picker.

BUG=670801
==========

to

==========
mash: Have chrome set itself as the wallpaper picker.

Rename WallpaperManager interface to WallpaperPicker.
Add WallpaperController::SetWallpaperPicker.

Chrome's WallpaperManager registers itself as picker on startup.
Ash's WallpaperController caches a ptr to the picker interface.
WallpaperManager interface no longer provided by Chrome.

Nix unused SetWallpaperImage return value.

BUG=670801
TEST=No wallpaper regressions in Classic ash or Mash.
R=jamescook@chromium.org
==========

[msw, 2016-12-07 18:11:15]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-12-07 18:11:25]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 18:11:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 18:40:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 18:40:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-12-07 19:02:24]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 19:02:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-12-07 19:42:31]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 19:42:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 20:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 20:43:42]

Dry run: This issue passed the CQ dry run.

[msw, 2016-12-07 20:44:15]

Hey James, please take a look; thanks!

[James Cook, 2016-12-07 23:03:47]

LGTM with a question, mostly about my own code.

https://codereview.chromium.org/2559503003/diff/60001/ash/common/wallpaper/wa...
File ash/common/wallpaper/wallpaper_controller.cc (right):

https://codereview.chromium.org/2559503003/diff/60001/ash/common/wallpaper/wa...
ash/common/wallpaper/wallpaper_controller.cc:191:
WmShell::Get()->wallpaper_delegate()->CanOpenSetWallpaperPage()) {
Aside: This will need to be mojo-ified someday.

https://codereview.chromium.org/2559503003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right):

https://codereview.chromium.org/2559503003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:829: if
(connection && connection->GetConnector()) {
Are you sure these can be null? Is that in tests?

I've written code that doesn't test for null for these... now I'm worried about
my code.

[msw, 2016-12-07 23:12:56]

https://codereview.chromium.org/2559503003/diff/60001/ash/common/wallpaper/wa...
File ash/common/wallpaper/wallpaper_controller.cc (right):

https://codereview.chromium.org/2559503003/diff/60001/ash/common/wallpaper/wa...
ash/common/wallpaper/wallpaper_controller.cc:191:
WmShell::Get()->wallpaper_delegate()->CanOpenSetWallpaperPage()) {
On 2016/12/07 23:03:47, James Cook wrote:
> Aside: This will need to be mojo-ified someday.

Perhaps... This is on the ash-side, so this particular usage is okay. It's
possible that Chrome should also check this before actually opening the picker,
but what we really need is a picker implemented in ash instead of Chrome...

https://codereview.chromium.org/2559503003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right):

https://codereview.chromium.org/2559503003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:829: if
(connection && connection->GetConnector()) {
On 2016/12/07 23:03:47, James Cook wrote:
> Are you sure these can be null? Is that in tests?
> 
> I've written code that doesn't test for null for these... now I'm worried
about
> my code.

Yes, the earlier patch sets failed because the connection is null; I verified
that locally. I think the potential for null is dependent upon the testing
conditions. This object is constructed in unit tests that don't initialize the
connection, but other connection users may not be invoked in such tests...

[msw, 2016-12-07 23:13:05]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-12-07 23:13:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 23:23:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 23:23:20]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2016-12-07 23:45:07]

Description was changed from

==========
mash: Have chrome set itself as the wallpaper picker.

Rename WallpaperManager interface to WallpaperPicker.
Add WallpaperController::SetWallpaperPicker.

Chrome's WallpaperManager registers itself as picker on startup.
Ash's WallpaperController caches a ptr to the picker interface.
WallpaperManager interface no longer provided by Chrome.

Nix unused SetWallpaperImage return value.

BUG=670801
TEST=No wallpaper regressions in Classic ash or Mash.
R=jamescook@chromium.org
==========

to

==========
mash: Have chrome set itself as the wallpaper picker.

Rename WallpaperManager interface to WallpaperPicker.
Add WallpaperController::SetWallpaperPicker.

Chrome's WallpaperManager registers itself as picker on startup.
Ash's WallpaperController caches a ptr to the picker interface.
WallpaperManager interface no longer provided by Chrome.

Nix unused SetWallpaperImage return value.

BUG=670801
TEST=No wallpaper regressions in Classic ash or Mash.
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,
==========

[msw, 2016-12-07 23:45:07]

msw@chromium.org changed reviewers:
+ tsepez@chromium.org, xiyuan@chromium.org

[msw, 2016-12-07 23:46:29]

Tom, please take a look at wallpaper.mojom and *manifest_overlay.json
Xiyuan, please take a look at c/b/chromeos/*
Thanks!

[xiyuan, 2016-12-07 23:48:40]

c/b/chromeos/* lgtm

[Tom Sepez, 2016-12-08 00:18:30]

mojom LGTM

[msw, 2016-12-08 00:29:30]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:29:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:29:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481156970504460,
"parent_rev": "4e7d683f5b9c64d99c42683615c58819039cd88b", "commit_rev":
"51296341b445f3a0aa60e5f7d4e14e205c77cb71"}

[commit-bot: I haz the power, 2016-12-08 01:30:25]

Description was changed from

==========
mash: Have chrome set itself as the wallpaper picker.

Rename WallpaperManager interface to WallpaperPicker.
Add WallpaperController::SetWallpaperPicker.

Chrome's WallpaperManager registers itself as picker on startup.
Ash's WallpaperController caches a ptr to the picker interface.
WallpaperManager interface no longer provided by Chrome.

Nix unused SetWallpaperImage return value.

BUG=670801
TEST=No wallpaper regressions in Classic ash or Mash.
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,
==========

to

==========
mash: Have chrome set itself as the wallpaper picker.

Rename WallpaperManager interface to WallpaperPicker.
Add WallpaperController::SetWallpaperPicker.

Chrome's WallpaperManager registers itself as picker on startup.
Ash's WallpaperController caches a ptr to the picker interface.
WallpaperManager interface no longer provided by Chrome.

Nix unused SetWallpaperImage return value.

BUG=670801
TEST=No wallpaper regressions in Classic ash or Mash.
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,
==========

[commit-bot: I haz the power, 2016-12-08 01:30:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-08 01:33:25]

Description was changed from

==========
mash: Have chrome set itself as the wallpaper picker.

Rename WallpaperManager interface to WallpaperPicker.
Add WallpaperController::SetWallpaperPicker.

Chrome's WallpaperManager registers itself as picker on startup.
Ash's WallpaperController caches a ptr to the picker interface.
WallpaperManager interface no longer provided by Chrome.

Nix unused SetWallpaperImage return value.

BUG=670801
TEST=No wallpaper regressions in Classic ash or Mash.
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,
==========

to

==========
mash: Have chrome set itself as the wallpaper picker.

Rename WallpaperManager interface to WallpaperPicker.
Add WallpaperController::SetWallpaperPicker.

Chrome's WallpaperManager registers itself as picker on startup.
Ash's WallpaperController caches a ptr to the picker interface.
WallpaperManager interface no longer provided by Chrome.

Nix unused SetWallpaperImage return value.

BUG=670801
TEST=No wallpaper regressions in Classic ash or Mash.
R=jamescook@chromium.org,tsepez@chromium.org,xiyuan@chromium.org,

Committed: https://crrev.com/6e6bcece082c7a57af4a436fe7599770543140a2
Cr-Commit-Position: refs/heads/master@{#437116}
==========

[commit-bot: I haz the power, 2016-12-08 01:33:26]

Patchset 4 (id:??) landed as
https://crrev.com/6e6bcece082c7a57af4a436fe7599770543140a2
Cr-Commit-Position: refs/heads/master@{#437116}