Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: telemetry/telemetry/internal/actions/loop.py

Issue 2559503002: [Telemetry] Fix JavaScript interpolation in telemetry actions (Closed)
Patch Set: inline js literals Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/actions/loop.py
diff --git a/telemetry/telemetry/internal/actions/loop.py b/telemetry/telemetry/internal/actions/loop.py
index 04c610b1164cd0124b488ca9e7e209dbe9026db1..91f9f47955d0ad442efa724335196556cbd51c3a 100644
--- a/telemetry/telemetry/internal/actions/loop.py
+++ b/telemetry/telemetry/internal/actions/loop.py
@@ -16,6 +16,7 @@ from telemetry.core import exceptions
from telemetry.internal.actions import media_action
from telemetry.internal.actions import page_action
from telemetry.internal.actions import utils
+from telemetry.util import js_template
class LoopAction(media_action.MediaAction):
@@ -32,10 +33,12 @@ class LoopAction(media_action.MediaAction):
utils.InjectJavaScript(tab, 'loop.js')
def RunAction(self, tab):
+ # TODO(catapult:#3028): Render in JavaScript method when supported by API.
+ code = js_template.Render(
+ 'window.__loopMedia({{ selector }}, {{ loop_count }});',
+ selector=self._selector, loop_count=self._loop_count)
try:
- # TODO(catapult:#3028): Fix interpolation of JavaScript values.
- tab.ExecuteJavaScript('window.__loopMedia("%s", %i);' %
- (self._selector, self._loop_count))
+ tab.ExecuteJavaScript(code)
if self._timeout_in_seconds > 0:
self.WaitForEvent(tab, self._selector, 'loop', self._timeout_in_seconds)
except exceptions.EvaluateException:
« no previous file with comments | « telemetry/telemetry/internal/actions/load_media_unittest.py ('k') | telemetry/telemetry/internal/actions/media_action.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698