Record user action of screen orientation change

Record user action of screen orientation change

In this CL, we record user action when the screen orientation has
changed. The purpose of this recording is to study the relationship
between fullscreen and screen orientation change.

BUG=671226
Committed: https://crrev.com/551bf496b3e6c42e573faf76dc64414d20e3bcbb
Cr-Commit-Position: refs/heads/master@{#437030}

[Zhiqiang Zhang (Slow), 2016-12-06 13:48:17]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-12-06 13:51:22]

lgtm. Thanks! :)

https://codereview.chromium.org/2559463002/diff/1/content/browser/android/con...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/2559463002/diff/1/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:892:
base::RecordAction(base::UserMetricsAction("OrientationChange"));
nit: I would call this "ScreenOrientationChange" to avoid confusion :)

[Zhiqiang Zhang (Slow), 2016-12-06 17:58:17]

zqzhang@chromium.org changed reviewers:
+ asvitkine@chromium.org, skyostil@chromium.org

[Zhiqiang Zhang (Slow), 2016-12-06 17:58:18]

+skyostil: content_view_core_impl.cc
+asvitkine: actions.xml

[Zhiqiang Zhang (Slow), 2016-12-06 17:58:44]

https://codereview.chromium.org/2559463002/diff/1/content/browser/android/con...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/2559463002/diff/1/content/browser/android/con...
content/browser/android/content_view_core_impl.cc:892:
base::RecordAction(base::UserMetricsAction("OrientationChange"));
On 2016/12/06 13:51:22, mlamouri wrote:
> nit: I would call this "ScreenOrientationChange" to avoid confusion :)

Done.

[Alexei Svitkine (slow), 2016-12-06 18:02:22]

lgtm % comment

https://codereview.chromium.org/2559463002/diff/20001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2559463002/diff/20001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:13638: The use rotates the device triggering a
screen orientation change.
Mention that this is Android-specific.

[Zhiqiang Zhang (Slow), 2016-12-07 11:53:57]

https://codereview.chromium.org/2559463002/diff/20001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2559463002/diff/20001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:13638: The use rotates the device triggering a
screen orientation change.
On 2016/12/06 18:02:22, Alexei Svitkine wrote:
> Mention that this is Android-specific.

Done.

[Sami, 2016-12-07 18:08:00]

content/browser/android/ lgtm.

[Zhiqiang Zhang (Slow), 2016-12-07 18:09:05]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-12-07 18:09:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2559463002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-12-07 18:09:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 19:29:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481134145604060,
"parent_rev": "94373f2aa799e78d4ed26a3f3018cef0e67f295a", "commit_rev":
"2044315191604dc4f7d7ca93c755d4f866cefd83"}

[commit-bot: I haz the power, 2016-12-07 19:30:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-07 19:34:15]

Description was changed from

==========
Record user action of screen orientation change

In this CL, we record user action when the screen orientation has
changed. The purpose of this recording is to study the relationship
between fullscreen and screen orientation change.

BUG=671226
==========

to

==========
Record user action of screen orientation change

In this CL, we record user action when the screen orientation has
changed. The purpose of this recording is to study the relationship
between fullscreen and screen orientation change.

BUG=671226

Committed: https://crrev.com/551bf496b3e6c42e573faf76dc64414d20e3bcbb
Cr-Commit-Position: refs/heads/master@{#437030}
==========

[commit-bot: I haz the power, 2016-12-07 19:34:16]

Patchset 3 (id:??) landed as
https://crrev.com/551bf496b3e6c42e573faf76dc64414d20e3bcbb
Cr-Commit-Position: refs/heads/master@{#437030}