Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2559443002: Let LayoutBlockFlow::removeFloatingObject take LayoutUnit instead of int. (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let LayoutBlockFlow::removeFloatingObject take LayoutUnit instead of int. Committed: https://crrev.com/bd4fdcd8d3ba4d63c688ab8984af09c6731a37ad Cr-Commit-Position: refs/heads/master@{#437221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mstensho (USE GERRIT)
4 years ago (2016-12-06 11:34:18 UTC) #4
szager1
lgtm
4 years ago (2016-12-07 23:02:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559443002/1
4 years ago (2016-12-08 07:39:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 09:31:23 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 09:35:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd4fdcd8d3ba4d63c688ab8984af09c6731a37ad
Cr-Commit-Position: refs/heads/master@{#437221}

Powered by Google App Engine
This is Rietveld 408576698