Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 255943007: Renaming --enable-font-smoothing cmd line argument to --enable-font-antialiasing (Closed)

Created:
6 years, 7 months ago by Dominik Röttsches
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Renaming --enable-font-smoothing cmd line argument to --enable-font-antialiasing Depends on Blink side change: https://codereview.chromium.org/258953005/ and should only be landed after this was landed and rolled. BUG=367082 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268192

Patch Set 1 #

Patch Set 2 : Preparing for landing as 4-sided patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M content/shell/browser/shell_content_browser_client.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/common/shell_switches.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/common/shell_switches.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/TestInterfaces.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Dominik Röttsches
6 years, 7 months ago (2014-04-28 12:22:08 UTC) #1
Dominik Röttsches
Chromium side change of already LGTM'ed Blink change https://codereview.chromium.org/258953005/
6 years, 7 months ago (2014-04-29 08:03:16 UTC) #2
dglazkov
lgtm
6 years, 7 months ago (2014-04-29 16:25:55 UTC) #3
Dominik Röttsches
I am planning to leave both switches, old and new in very temporarily, until I ...
6 years, 7 months ago (2014-04-30 11:41:46 UTC) #4
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 7 months ago (2014-05-02 08:43:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/255943007/20001
6 years, 7 months ago (2014-05-02 08:43:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 08:46:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-05-02 08:46:35 UTC) #8
Dominik Röttsches
I would need an OWNER rubberstamp, thanks.
6 years, 7 months ago (2014-05-02 09:01:24 UTC) #9
jam
lgtm
6 years, 7 months ago (2014-05-02 18:34:21 UTC) #10
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 7 months ago (2014-05-05 15:52:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/255943007/20001
6 years, 7 months ago (2014-05-05 15:52:17 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 16:32:20 UTC) #13
Message was sent while issue was closed.
Change committed as 268192

Powered by Google App Engine
This is Rietveld 408576698