Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: README.chromium

Issue 255943004: Add icudt.dll for Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/
Patch Set: Add icudt.dll for Windows Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | patches/data.build.win.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.chromium
===================================================================
--- README.chromium (revision 266014)
+++ README.chromium (working copy)
@@ -145,8 +145,7 @@
- patches/data.build.patch :
Remove unnecessary resources : invuca, unames, collator source, stringprep
- patches/data.build.win.patch :
- Windows-only data build patch. Add a new target DATALIB to makedata.mak
- - add an empty file (stubdatabuilt.txt) to source/stubdata
+ Windows-only data build patch.
9. Pre-built data files are checked in with the following steps on Linux:
@@ -172,13 +171,6 @@
{BUILD_DIR_ROOT}/data/out/tmp and copied to the above location with a
version number (52) dropped.
- - windows/icudt.dll : With icudt52l.dat in place, all the patches applied
- and header files moved (#11 below), generated by building icudt_build
- project of build/icudt_build.sln on Windows. icudt52.dll is
- generated in bin/{Release,Debug} and copied to windows/icudt.dll
- and checked in. Note that we drop the version number ('52') from the
- dll name to avoind having to update our build scripts/configuration
- files everytime ICU is upgraded to a new version.
- {mac,linux}/icudtl_dat.S : Built on Linux with all the
patches above (except android/brkitr.patch) applied and checked in.
@@ -185,20 +177,10 @@
This file will be generated in {BUILD_DIR_ROOT}/data/out/tmp as
icudt52l_dat.S, but '52' is dropped while copying.
- mac/icudtl_dat.S is identical to linux/icudtl_dat.S. It's made
- by changing the header portion of the Linux version to read as following
- (no leading whitespace) :
+ mac/icudtl_dat.S is identical to linux/icudtl_dat.S except for
+ the header portion. With "linux/icudtl_dat.S" in its place,
+ run scripts/make_mac_assembly.sh to generate it.
- .globl _icudt52_dat
- #ifdef U_HIDE_DATA_SYMBOL
- .private_extern _icudt52_dat
- #endif
- .data
- .const
- .align 4
- _icudt52_dat:
-
-
- android/icudtl_dat.S : Built on Linux with all the patches above and
android/brkitr.patch applied and android/patch_locale.sh executed.
'52' is dropped from the name generated in the build tree.
@@ -207,6 +189,25 @@
{BUILD_DIR_ROOT}/data/out/tmp along with icudt52l_dat.S and
copied to the above location with '52' dropped in its name.
+ - windows/icudt.dll (by default, we set icu_use_icu_data_flag to 1
+ and don't use this file.)
+ a. check out a clean copy of icu52 from the upstream on Windows
+ outside the Chrome tree.
+
+ $ svn export --native-eol LF http://source.icu-project.org/repos/icu/icu/tags/release-52-1 ${SEPARATE_ICU_ROOT}/icu52
+
+ b. copy ${CHROME_ICU_ROOT}/source/data/in/icudtl.dat to
+ ${SEPARATE_ICU_ROOT}/source/data/in/icudt52l.dat
+ c. copy ${CHROME_ICU_ROOT}/source/data/makedata.mak to
+ ${SEPARATE_ICU_ROOT}/source/data/makedata.mak
+ c. In Visual Studio, open source/allinone/allinone.sln solution
+ in ${SEPARATE_ICU_ROOT}
+ d. Build 'makedata' target
+ e. icudt52.dll will be generated in ${SEPARATE_ICU_ROOT}/bin
+ f. Copy that icudt52.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll
+ and check that in.
+
+
10. Change export of U_ICUDATA_ENTRY_POINT from U_IMPORT to U_EXPORT.
- patches/declspec.patch
« no previous file with comments | « no previous file | patches/data.build.win.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698