Add icudt.dll for Windows

scripts/make_mac_assembly.sh

+#!/bin/sh
+# Copyright (c) 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+ICUROOT="$(dirname $0)/.."
+LINUX_SOURCE="${ICUROOT}/linux/icudtl_dat.S"
+MAC_SOURCE="${ICUROOT}/mac/icudtl_dat.S"
+
+cat > ${MAC_SOURCE} <<PREAMBLE
+.globl _icudt52_dat

[Mark Mentovai, 2014/04/25 21:00:32]

I thought we were going to get rid of the version number from here too.

[jungshik at Google, 2014/04/26 00:20:02]

That does not earn us anything. We wanna get rid of the version number from the
filenames so that we don't have to track down every single reference of icudtXX
in our build/source files when updating icu.(e.g. http://goo.gl/Dhtdxm in skia's
v8.gyp) 

OTOH, all the icu symbols carry version number anyway (to get rid of them will
require an additional patch and will add a maintenance burden [2] ) and
icu_util.cc (in chrome tree and v8 tree) has the following (no need to change
manually):

#elif ICU_UTIL_DATA_IMPL == ICU_UTIL_DATA_SHARED
#define ICU_UTIL_DATA_SYMBOL "icudt" U_ICU_VERSION_SHORT "_dat"
#if defined(OS_WIN)
#define ICU_UTIL_DATA_SHARED_MODULE_NAME "icudt.dll"
#endif


So, I'd just leave it alone here.

[2] To get rid of the version number from icudt.dll may require more 'hackery'
on Windows. (getting rid of that in the assembly source is easy)

+#ifdef U_HIDE_DATA_SYMBOL
+       .private_extern _icudt52_dat
+#endif
+       .data
+       .const
+       .align 4
+_icudt52_dat:
+PREAMBLE
+
+tail -n +10 ${LINUX_SOURCE} >> ${MAC_SOURCE}

[Mark Mentovai, 2014/04/25 21:00:32]

The fixed “10” is weird, there’s no check to see whether too much or too little
got chopped off. You could just organize this as a patch, then at least if the
input data changes, there’d be a signal that manual attention is needed.

[jungshik at Google, 2014/04/26 00:20:02]

How about patch set 3? I detect '^icudt' in the Linux assembly (which is at the
end of the header) and count # of lines up to that point. 

As you said, with a patch, I have to manually fix it when the first few lines of
the body change (which happens often with the data update).