Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 255943003: Add explicit constructors with field initializers. (Closed)

Created:
6 years, 8 months ago by rpaquay
Modified:
6 years, 7 months ago
Reviewers:
keybuk
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add explicit constructors with field initializers. * Also add explicit destructors (to decrease code size due to inlining) BUG=365101 . Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M device/bluetooth/bluetooth_task_manager_win.h View 1 chunk +6 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_task_manager_win.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
rpaquay
6 years, 8 months ago (2014-04-25 19:02:01 UTC) #1
keybuk
lgtm
6 years, 8 months ago (2014-04-25 20:01:25 UTC) #2
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 7 months ago (2014-04-28 17:28:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/255943003/1
6 years, 7 months ago (2014-04-28 17:29:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 17:35:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 17:35:49 UTC) #6
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 7 months ago (2014-04-28 19:53:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/255943003/1
6 years, 7 months ago (2014-04-28 19:55:06 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 20:08:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 20:08:22 UTC) #10
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 7 months ago (2014-04-28 20:13:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/255943003/1
6 years, 7 months ago (2014-04-28 20:14:59 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 20:49:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 20:49:43 UTC) #14
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 7 months ago (2014-04-29 15:19:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/255943003/1
6 years, 7 months ago (2014-04-29 15:19:39 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 03:05:23 UTC) #17
Message was sent while issue was closed. 
Change committed as 267054

Powered by Google App Engine
This is Rietveld 408576698