Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: media/gpu/jpeg_decode_accelerator_unittest.cc

Issue 2559423002: media/gpu: switch v4l2_jpeg_decode_accelerator to use multi-planar APIs (Closed)
Patch Set: remove PIXEL_FORMAT_I422 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/jpeg_decode_accelerator_unittest.cc
diff --git a/media/gpu/jpeg_decode_accelerator_unittest.cc b/media/gpu/jpeg_decode_accelerator_unittest.cc
index cc5e2c60d0dad93251d8c3975350315eae704dc0..868512a7e09d83ab89b5f7e4fc4b77ffe00ef019 100644
--- a/media/gpu/jpeg_decode_accelerator_unittest.cc
+++ b/media/gpu/jpeg_decode_accelerator_unittest.cc
@@ -137,8 +137,7 @@ void JpegClient::CreateJpegDecoder() {
decoder_.reset(
new VaapiJpegDecodeAccelerator(base::ThreadTaskRunnerHandle::Get()));
#elif defined(OS_CHROMEOS) && defined(USE_V4L2_CODEC)
- scoped_refptr<V4L2Device> device =
- V4L2Device::Create(V4L2Device::kJpegDecoder);
+ scoped_refptr<V4L2Device> device = V4L2Device::Create();
wuchengli 2016/12/15 09:18:25 Hmm. This means JDA is not run by autotest... I ne
if (!device.get()) {
LOG(ERROR) << "V4L2Device::Create failed";
SetState(CS_ERROR);
@@ -562,7 +561,8 @@ int main(int argc, char** argv) {
}
if (it->first == "v" || it->first == "vmodule")
continue;
- LOG(FATAL) << "Unexpected switch: " << it->first << ":" << it->second;
+ LOG(ERROR) << "Unexpected switch: " << it->first << ":" << it->second;
wuchengli 2016/12/15 09:18:25 What's this for?
jcliang 2016/12/15 14:55:47 LOG(FATAL) generates core dumps and it wasted disk
+ return 0;
}
#if defined(OS_CHROMEOS) && defined(ARCH_CPU_X86_FAMILY)
media::VaapiWrapper::PreSandboxInitialization();

Powered by Google App Engine
This is Rietveld 408576698