Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 25594002: Revert homogenize msvs and ninja library_dir and libraries settings for (Closed)

Created:
7 years, 2 months ago by scottmg
Modified:
7 years, 2 months ago
Reviewers:
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Revert homogenize msvs and ninja library_dir and libraries settings for Committed: https://code.google.com/p/gyp/source/detail?r=1744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -84 lines) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +2 lines, -2 lines 0 comments Download
M pylib/gyp/msvs_emulation.py View 1 chunk +1 line, -2 lines 0 comments Download
M test/library_dirs/gyptest-library-dirs.py View 2 chunks +0 lines, -17 lines 0 comments Download
M test/library_dirs/subdir/test.gyp View 1 chunk +11 lines, -3 lines 0 comments Download
D test/library_dirs/subdir/test-win.gyp View 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
scottmg
7 years, 2 months ago (2013-10-01 20:00:47 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r1744.

Powered by Google App Engine
This is Rietveld 408576698