third_party/WebKit/Source/bindings/scripts/v8_union.py - Issue 2559323004: bindings: Stop using forward declarations for typed array in union containers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_union.py

Issue 2559323004: bindings: Stop using forward declarations for typed array in union containers (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_union.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_union.py b/third_party/WebKit/Source/bindings/scripts/v8_union.py

index 407d2c16c7dda7bdae785d1ba88014318c2d4ecb..84dd56bd855e95f52b2fe19542e90d829d7afe9a 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_union.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_union.py

@@ -121,7 +121,7 @@ def _update_includes_and_forward_decls(member, interface_info):

cpp_includes.update(interface_info.get(

'dependencies_include_paths', []))

# We need complete types for IDL dictionaries in union containers.

- if member.is_dictionary:

+ if member.is_dictionary or member.is_typed_array:

header_includes.update(member.includes_for_type())

else:

cpp_includes.update(member.includes_for_type())

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.h » ('j') | no next file with comments »