third_party/WebKit/Source/platform/animation/CompositorAnimationHostTest.cpp - Issue 2559273003: Blink Compositor Animation: Introduce CompositorAnimationHost correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/animation/CompositorAnimationHostTest.cpp

Issue 2559273003: Blink Compositor Animation: Introduce CompositorAnimationHost correctly. (Closed)

Patch Set: Allocate on stack in unit tests. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/animation/CompositorAnimationHost.cpp ('k') | third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/animation/CompositorAnimationHostTest.cpp

diff --git a/third_party/WebKit/Source/platform/animation/CompositorAnimationHostTest.cpp b/third_party/WebKit/Source/platform/animation/CompositorAnimationHostTest.cpp

index d564b80f535556ed43930eeedd4e8ac47594c605..8611347ddf9c59be72b9de0cca49541099e4a30a 100644

--- a/third_party/WebKit/Source/platform/animation/CompositorAnimationHostTest.cpp

+++ b/third_party/WebKit/Source/platform/animation/CompositorAnimationHostTest.cpp

@@ -8,7 +8,6 @@

#include "platform/animation/CompositorAnimationTimeline.h"

#include "platform/testing/CompositorTest.h"

#include "platform/testing/WebLayerTreeViewImplForTesting.h"

-#include "wtf/PtrUtil.h"

#include <memory>

namespace blink {

@@ -22,19 +21,16 @@ TEST_F(CompositorAnimationHostTest, AnimationHostNullWhenTimelineDetached) {

scoped_refptr<cc::AnimationTimeline> ccTimeline =

timeline->animationTimeline();

EXPECT_FALSE(ccTimeline->animation_host());

- EXPECT_TRUE(timeline->compositorAnimationHost().isNull());

- std::unique_ptr<WebLayerTreeView> layerTreeHost =

- WTF::wrapUnique(new WebLayerTreeViewImplForTesting);

- DCHECK(layerTreeHost);

+ WebLayerTreeViewImplForTesting layerTreeView;

+ CompositorAnimationHost compositorAnimationHost(

+ layerTreeView.compositorAnimationHost());

- layerTreeHost->attachCompositorAnimationTimeline(

- timeline->animationTimeline());

- EXPECT_FALSE(timeline->compositorAnimationHost().isNull());

+ compositorAnimationHost.addTimeline(*timeline);

+ EXPECT_TRUE(ccTimeline->animation_host());

- layerTreeHost->detachCompositorAnimationTimeline(

- timeline->animationTimeline());

- EXPECT_TRUE(timeline->compositorAnimationHost().isNull());

+ compositorAnimationHost.removeTimeline(*timeline);

+ EXPECT_FALSE(ccTimeline->animation_host());

}

} // namespace blink