Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2559243002: [Mac] RTL-aware drawing for keyword hint decoration (Closed)

Created:
4 years ago by lgrey
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] RTL-aware drawing for keyword hint decoration BUG=648557 Committed: https://crrev.com/c2706cca2d666501c5d1319798e3a7ec7add4ca1 Cr-Commit-Position: refs/heads/master@{#437626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm View 3 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
lgrey
PTAL :)
4 years ago (2016-12-08 18:28:04 UTC) #2
Elly Fong-Jones
lgtm
4 years ago (2016-12-09 18:58:49 UTC) #3
lgrey
On 2016/12/09 18:58:49, Elly Fong-Jones wrote: > lgtm Thanks!
4 years ago (2016-12-09 19:00:27 UTC) #4
lgrey
Avi PTAL for OWNERS
4 years ago (2016-12-09 19:01:08 UTC) #9
Avi (use Gerrit)
lgtm
4 years ago (2016-12-09 19:06:51 UTC) #10
lgrey
Thanks!
4 years ago (2016-12-09 19:08:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559243002/1
4 years ago (2016-12-09 19:09:17 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 20:34:41 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-12 14:39:53 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2706cca2d666501c5d1319798e3a7ec7add4ca1
Cr-Commit-Position: refs/heads/master@{#437626}

Powered by Google App Engine
This is Rietveld 408576698