Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 255923002: Instrumented libraries: refactor build scripts. (Closed)

Created:
6 years, 8 months ago by earthdok
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Instrumented libraries: refactor build scripts. Mostly naming changes. Also, improve verbosity flag handling. BUG=313751 R=glider@chromium.org NOTRY=true TEST=msan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -55 lines) Patch
M third_party/instrumented_libraries/download_build_install.py View 7 chunks +17 lines, -17 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 19 chunks +26 lines, -31 lines 0 comments Download
M third_party/instrumented_libraries/standard_instrumented_library_target.gypi View 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
earthdok
ptal now is a good time to land this, since both this and the previous ...
6 years, 8 months ago (2014-04-25 15:35:25 UTC) #1
Alexander Potapenko
LGTM
6 years, 8 months ago (2014-04-25 15:42:28 UTC) #2
earthdok
6 years, 8 months ago (2014-04-25 15:44:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r266199 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698