Use python's unittest framework.

Use python's unittest framework.

BUG=669956
Committed: https://crrev.com/5cec963820cba6be09871fceef8ccfc8f62fa36a
Cr-Commit-Position: refs/heads/master@{#437413}

[Robert Ogden, 2016-12-08 22:54:38]

Description was changed from

==========
Use python's unittest framework.

BUG=
==========

to

==========
Use python's unittest framework.

BUG=669956
==========

[Robert Ogden, 2016-12-08 22:54:38]

robertogden@chromium.org changed reviewers:
+ sclittle@chromium.org

[sclittle, 2016-12-08 23:14:00]

This is awesome, thanks!

LGTM % nit

https://codereview.chromium.org/2559113005/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/simple_smoke.py (right):

https://codereview.chromium.org/2559113005/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/simple_smoke.py:39: # Give a different argv so that
unittest won't get in the way of our argparse.
nit: pardon my ignorance, but I don't know what this means :) could you explain
it a bit more perhaps?

Is it that sys.argv has a bunch of our integration-test specific args and we
don't want to pass those to unittest.main?

[robertogden, 2016-12-08 23:19:29]

robertogden@google.com changed reviewers:
+ robertogden@google.com

[robertogden, 2016-12-08 23:19:30]

https://codereview.chromium.org/2559113005/diff/20001/tools/chrome_proxy/webd...
File tools/chrome_proxy/webdriver/simple_smoke.py (right):

https://codereview.chromium.org/2559113005/diff/20001/tools/chrome_proxy/webd...
tools/chrome_proxy/webdriver/simple_smoke.py:39: # Give a different argv so that
unittest won't get in the way of our argparse.
On 2016/12/08 23:14:00, sclittle wrote:
> nit: pardon my ignorance, but I don't know what this means :) could you
explain
> it a bit more perhaps?
> 
> Is it that sys.argv has a bunch of our integration-test specific args and we
> don't want to pass those to unittest.main?

How's that?

[sclittle, 2016-12-08 23:20:08]

still LGTM

[Robert Ogden, 2016-12-08 23:20:15]

The CQ bit was checked by robertogden@chromium.org

[commit-bot: I haz the power, 2016-12-08 23:20:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:36:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481239215517720,
"parent_rev": "2802fae235c749d876894ba472202d65c4ee8901", "commit_rev":
"7c32a15001334cd8347f3773d5ca0b5f8a92af65"}

[commit-bot: I haz the power, 2016-12-09 01:36:51]

Description was changed from

==========
Use python's unittest framework.

BUG=669956
==========

to

==========
Use python's unittest framework.

BUG=669956
==========

[commit-bot: I haz the power, 2016-12-09 01:36:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-09 01:40:27]

Description was changed from

==========
Use python's unittest framework.

BUG=669956
==========

to

==========
Use python's unittest framework.

BUG=669956

Committed: https://crrev.com/5cec963820cba6be09871fceef8ccfc8f62fa36a
Cr-Commit-Position: refs/heads/master@{#437413}
==========

[commit-bot: I haz the power, 2016-12-09 01:40:28]

Patchset 3 (id:??) landed as
https://crrev.com/5cec963820cba6be09871fceef8ccfc8f62fa36a
Cr-Commit-Position: refs/heads/master@{#437413}