Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2559083002: X87: Store OSR'd optimized code on the native context. (Closed)

Created:
4 years ago by zhengxing.li
Modified:
4 years ago
Reviewers:
mvstanton, chunyang.dai
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Store OSR'd optimized code on the native context. port 378b6b22fb7925ac5b672335a54599f5739e7758 (r41554) original commit message: Since we OSR code rarely, it makes sense to store it and look for it on the native context rather than the SharedFunctionInfo. This makes the OptimizedCodeMap data structure more space efficient, as it doesn't have to store an ast ID for the OSR entry point. BUG= Committed: https://crrev.com/007a18656e28caca15c4fa81199d540c13dba244 Cr-Commit-Position: refs/heads/master@{#41606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/builtins/x87/builtins-x87.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
zhengxing.li
PTAL, thanks!
4 years ago (2016-12-08 02:17:20 UTC) #2
chunyang.dai
LGTM. thanks
4 years ago (2016-12-08 06:43:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559083002/1
4 years ago (2016-12-08 06:44:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559083002/1
4 years ago (2016-12-09 01:43:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 06:55:40 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-09 06:56:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/007a18656e28caca15c4fa81199d540c13dba244
Cr-Commit-Position: refs/heads/master@{#41606}

Powered by Google App Engine
This is Rietveld 408576698