Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2559073002: CSS Motion Path: Support offset-rotate in addition to offset-rotation (Closed)

Created:
4 years ago by Eric Willigers
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

CSS Motion Path: Support offset-rotate in addition to offset-rotation offset-rotation is being renamed to offset-rotate, but we will already have shipped offset-rotation. We 'alias' offset-rotate to offset-rotation, sharing storage in ComputedStyle. Spec discussion: https://github.com/w3c/fxtf-drafts/issues/70 Design Docs: https://goo.gl/XFvGR8 https://docs.google.com/document/d/1AHSyz3_Qu8hZK5czcQdfucVanoxpsUkBbzY16ti4_NY/edit?usp=sharing BUG=671333 Review-Url: https://codereview.chromium.org/2555543002 Cr-Commit-Position: refs/heads/master@{#436835} (cherry picked from commit af51f3582ab7798d8a58628c6975f7c08df8c8a2) Committed: https://chromium.googlesource.com/chromium/src/+/e35b7e19bbb795da9ab17c9e27e58c02656823fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -24 lines) Patch
A third_party/WebKit/LayoutTests/animations/composition/offset-rotate-composition.html View 1 chunk +94 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/interpolation/offset-rotate-interpolation.html View 1 chunk +145 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/responsive/offset-rotate-responsive.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/motion-path/offset-rotate.html View 1 chunk +70 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/fast/css/getComputedStyle/computed-style-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/svg/css/getComputedStyle-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Eric Willigers
4 years ago (2016-12-08 02:15:10 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e35b7e19bbb795da9ab17c9e27e58c02656823fe.

Powered by Google App Engine
This is Rietveld 408576698