third_party/WebKit/Source/wtf/MathExtras.h - Issue 2559063002: Don't define log2 and log2f in blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/MathExtras.h

Issue 2559063002: Don't define log2 and log2f in blink (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/MathExtras.h

diff --git a/third_party/WebKit/Source/wtf/MathExtras.h b/third_party/WebKit/Source/wtf/MathExtras.h

index 36ad81241aeea2d7b31f5a71d4bb5df9fc610ec2..6ff82028f7163fcc7a06966151bfd4bfd296f06f 100644

--- a/third_party/WebKit/Source/wtf/MathExtras.h

+++ b/third_party/WebKit/Source/wtf/MathExtras.h

@@ -59,8 +59,8 @@ const float piOverFourFloat = static_cast<float>(M_PI_4);

const double twoPiDouble = piDouble * 2.0;

const float twoPiFloat = piFloat * 2.0f;

-#if OS(ANDROID) || COMPILER(MSVC)

-// ANDROID and MSVC's math.h does not currently supply log2 or log2f.

+#if OS(ANDROID)

+// ANDROID's math.h does not currently supply log2 or log2f.

inline double log2(double num) {

// This constant is roughly M_LN2, which is not provided by default on Windows

// and Android.

« no previous file with comments | « no previous file | no next file » | no next file with comments »