Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 255903004: NaCl Sandbox: close low-level IPC channel in Non-SFI mode (Closed)

Created:
6 years, 8 months ago by jln (very slow on Chromium)
Modified:
6 years, 8 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, mdempsky
Visibility:
Public.

Description

NaCl Sandbox: close low-level IPC channel in Non-SFI mode In Non-SFI mode, we close the low-level kSandboxIPCChannel channel. BUG=367263, 358719 R=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266375

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M components/nacl/loader/nacl_helper_linux.cc View 1 3 chunks +29 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jln (very slow on Chromium)
Mark: PTAL!
6 years, 8 months ago (2014-04-25 22:26:26 UTC) #1
Mark Seaborn
LGTM https://codereview.chromium.org/255903004/diff/1/components/nacl/loader/nacl_helper_linux.cc File components/nacl/loader/nacl_helper_linux.cc (right): https://codereview.chromium.org/255903004/diff/1/components/nacl/loader/nacl_helper_linux.cc#newcode142 components/nacl/loader/nacl_helper_linux.cc:142: // should only be close in Non-SFI mode. ...
6 years, 8 months ago (2014-04-25 22:59:54 UTC) #2
jln (very slow on Chromium)
Thanks! https://codereview.chromium.org/255903004/diff/1/components/nacl/loader/nacl_helper_linux.cc File components/nacl/loader/nacl_helper_linux.cc (right): https://codereview.chromium.org/255903004/diff/1/components/nacl/loader/nacl_helper_linux.cc#newcode142 components/nacl/loader/nacl_helper_linux.cc:142: // should only be close in Non-SFI mode. ...
6 years, 8 months ago (2014-04-25 23:40:55 UTC) #3
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 8 months ago (2014-04-26 16:42:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/255903004/20001
6 years, 8 months ago (2014-04-26 16:43:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 17:26:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-26 17:26:29 UTC) #7
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 8 months ago (2014-04-26 20:34:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/255903004/20001
6 years, 8 months ago (2014-04-26 20:34:46 UTC) #9
jln (very slow on Chromium)
6 years, 8 months ago (2014-04-26 22:07:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r266375 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698