Use base::STLSet* in place of std::set_* for simplicity and consistency.

Use base::STLSet* in place of std::set_* for simplicity and consistency.

BUG=254066
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266403

[Sungmann Cho, 2014-04-25 14:17:19]

Please take a look. Thanks.

[Jeffrey Yasskin, 2014-04-25 15:14:23]

lgtm

https://codereview.chromium.org/255903002/diff/20001/extensions/common/url_pa...
File extensions/common/url_pattern_set.cc (right):

https://codereview.chromium.org/255903002/diff/20001/extensions/common/url_pa...
extensions/common/url_pattern_set.cc:40: out->patterns_ =
base::STLSetIntersection<std::set<URLPattern> >(
Since you're reassigning patterns_ instead of appending to it, there's also no
more need to call ClearPatterns.

[Sungmann Cho, 2014-04-25 15:39:23]

You're right! So we can remove the same line in other siblings.

https://codereview.chromium.org/255903002/diff/20001/extensions/common/url_pa...
File extensions/common/url_pattern_set.cc (right):

https://codereview.chromium.org/255903002/diff/20001/extensions/common/url_pa...
extensions/common/url_pattern_set.cc:40: out->patterns_ =
base::STLSetIntersection<std::set<URLPattern> >(
On 2014/04/25 15:14:23, Jeffrey Yasskin wrote:
> Since you're reassigning patterns_ instead of appending to it, there's also no
> more need to call ClearPatterns.

Done.

[Sungmann Cho, 2014-04-25 15:44:31]

The CQ bit was checked by sungmann.cho@navercorp.com

[Sungmann Cho, 2014-04-25 21:36:50]

The CQ bit was unchecked by sungmann.cho@navercorp.com

[Sungmann Cho, 2014-04-25 21:37:00]

The CQ bit was checked by sungmann.cho@navercorp.com

[commit-bot: I haz the power, 2014-04-25 22:00:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/255903002/4...

[commit-bot: I haz the power, 2014-04-25 23:13:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:13:51]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Sungmann Cho, 2014-04-26 00:59:28]

The CQ bit was checked by sungmann.cho@navercorp.com

[commit-bot: I haz the power, 2014-04-26 01:00:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/255903002/4...

[commit-bot: I haz the power, 2014-04-26 04:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 04:14:50]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[Sungmann Cho, 2014-04-26 05:04:00]

The CQ bit was checked by sungmann.cho@navercorp.com

[commit-bot: I haz the power, 2014-04-26 05:05:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/255903002/4...

[commit-bot: I haz the power, 2014-04-27 00:28:06]

Change committed as 266403