third_party/WebKit/Source/platform/DragImage.cpp - Issue 2559013002: Add ColorBehavior to blink::Image draw methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/DragImage.cpp

Issue 2559013002: Add ColorBehavior to blink::Image draw methods (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/DragImage.cpp

diff --git a/third_party/WebKit/Source/platform/DragImage.cpp b/third_party/WebKit/Source/platform/DragImage.cpp

index c4cbd565dc0bbe9c09f70d9aea48cad7add89788..76047fa1191388a8bbb0f14ebdb1b5f0d92815c1 100644

--- a/third_party/WebKit/Source/platform/DragImage.cpp

+++ b/third_party/WebKit/Source/platform/DragImage.cpp

@@ -150,7 +150,10 @@ std::unique_ptr<DragImage> DragImage::create(

if (!image)

return nullptr;

- sk_sp<SkImage> skImage = image->imageForCurrentFrame();

+ // TODO(ccameron): DragImage needs to be color space aware.

+ // https://crbug.com/672316

+ sk_sp<SkImage> skImage =

+ image->imageForCurrentFrame(ColorBehavior::transformToGlobalTarget());

if (!skImage)

return nullptr;