third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp - Issue 2559013002: Add ColorBehavior to blink::Image draw methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

Issue 2559013002: Add ColorBehavior to blink::Image draw methods (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

index d3fb0e25fd12d224c0cfb32603fb0776ed59ae46..ddafd62e7a398a28af62161b8a158ac9bf9e65d9 100644

--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp

@@ -1078,8 +1078,11 @@ void BaseRenderingContext2D::drawImageInternal(SkCanvas* c,

if (!imageSource->isVideoElement()) {

imagePaint.setAntiAlias(shouldDrawImageAntialiased(dstRect));

+ // TODO(ccameron): Canvas should draw in sRGB by default.

+ // https://crbug.com/672299

image->draw(c, imagePaint, dstRect, srcRect, DoNotRespectImageOrientation,

- Image::DoNotClampImageToSourceRect);

+ Image::DoNotClampImageToSourceRect,

+ ColorBehavior::transformToGlobalTarget());

} else {

c->save();

c->clipRect(dstRect);