Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2559003002: [TTS] Fix testLongPressSwipeExpand flakiness. (Closed)

Created:
4 years ago by Donn Denman
Modified:
4 years ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Fix testLongPressSwipeExpand flakiness. Rework testLongPressSwipeExpand to use the newer way of starting a search and a more robust way to expand the panel. Hopefully that this makes this test less flaky. BUG=671627 Committed: https://crrev.com/8dea2db07061597d1cc4b30e087286ebe5e90383 Cr-Commit-Position: refs/heads/master@{#437121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 1 chunk +6 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Donn Denman
Theresa, PTAL.
4 years ago (2016-12-07 23:08:22 UTC) #2
Theresa
lgtm
4 years ago (2016-12-07 23:51:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559003002/1
4 years ago (2016-12-07 23:51:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 01:41:40 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-08 01:44:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dea2db07061597d1cc4b30e087286ebe5e90383
Cr-Commit-Position: refs/heads/master@{#437121}

Powered by Google App Engine
This is Rietveld 408576698