Issue 25590002: Release partially constructed GLES2 implementation in Pepper Graphics3D resource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25590002: Release partially constructed GLES2 implementation in Pepper Graphics3D resource. (Closed)

Created:
7 years, 2 months ago by bbudge

Modified:
7 years, 2 months ago

Reviewers:
dmichael (off chromium), inferno

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Release partially constructed GLES2 implementation in Pepper Graphics3D resource. Remove a guard which prevents destruction of the GLES2 implementation in cases where an error causes only partial construction. Otherwise, the CommandBufferHelper destructor will access the CommandBuffer after it has been destroyed. BUG=285578 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226354

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	ppapi/proxy/ppb_graphics_3d_proxy.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/25590002/1

7 years, 2 months ago (2013-10-01 20:42:20 UTC) #3

Message was sent while issue was closed.

Change committed as 226354

Expand Messages | Collapse Messages