Issue 2558993005: Revert "Add optional message argument to assert statements in the VM."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2558993005: Revert "Add optional message argument to assert statements in the VM." (Closed)

Created:
4 years ago by hausner

Modified:
4 years ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Add optional message argument to assert statements in the VM." This reverts commit 67e83dd79d1e8b58ef5a73dcf7cfc2fb22b108b6. BUG= Committed: https://github.com/dart-lang/sdk/commit/156fdef01d2594ed8429dc184c1ae3c3c598f6c2

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -171 lines)			Patch
M	runtime/lib/errors.cc	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/lib/errors_patch.dart	View	3 chunks	+17 lines, -20 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	3 chunks	+7 lines, -41 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/core/errors.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
D	tests/language/assert_message_test.dart	View	1 chunk	+0 lines, -99 lines	0 comments	Download

Total messages: 2 (1 generated)

hausner

4 years ago (2016-12-09 17:50:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
156fdef01d2594ed8429dc184c1ae3c3c598f6c2 (presubmit successful).