Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2558993002: Remove more unnecessary includes, limits.h and climits in base/numerics (Closed)

Created:
4 years ago by scottmg
Modified:
4 years ago
Reviewers:
jschuh
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove more unnecessary includes, limits.h and climits in base/numerics BUG=668713 R=jschuh@chromium.org Committed: https://crrev.com/ef3f35d7e604af1c77304a8692fc2d936fc024df Cr-Commit-Position: refs/heads/master@{#437276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M base/numerics/safe_conversions_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
scottmg
4 years ago (2016-12-07 22:35:59 UTC) #1
jschuh
On 2016/12/07 22:35:59, scottmg wrote: Interesting. I know climits isn't needed because I removed all ...
4 years ago (2016-12-08 13:55:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558993002/1
4 years ago (2016-12-08 13:56:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82280)
4 years ago (2016-12-08 16:22:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558993002/1
4 years ago (2016-12-08 16:48:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 17:44:37 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-08 17:46:52 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef3f35d7e604af1c77304a8692fc2d936fc024df
Cr-Commit-Position: refs/heads/master@{#437276}

Powered by Google App Engine
This is Rietveld 408576698