Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2558973004: Add cloud print to the chrome_official_builder_no_unittests group. (Closed)

Created:
4 years ago by pastarmovj
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cloud print to the chrome_official_builder_no_unittests group. BUG=671917 TEST=The official.desktop builder doesn't fail anymore. Committed: https://crrev.com/ae3050e85ea1680090ff2aee26d6f0beef4b8770 Cr-Commit-Position: refs/heads/master@{#437245}

Patch Set 1 #

Patch Set 2 : Comma missing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
pastarmovj
Hi Jochen, can you please review this one-liner. Thanks, Julian
4 years ago (2016-12-08 13:44:34 UTC) #2
jochen (gone - plz use gerrit)
lgtm with an additional comma :)
4 years ago (2016-12-08 13:48:34 UTC) #7
pastarmovj
On 2016/12/08 13:48:34, jochen wrote: > lgtm with an additional comma :) Lol backspace in ...
4 years ago (2016-12-08 13:50:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558973004/20001
4 years ago (2016-12-08 13:52:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 15:13:32 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 15:15:45 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae3050e85ea1680090ff2aee26d6f0beef4b8770
Cr-Commit-Position: refs/heads/master@{#437245}

Powered by Google App Engine
This is Rietveld 408576698