Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2558973002: Add missing paint invalidation when creating canvas 2d context with no alpha (Closed)

Created:
4 years ago by Justin Novosad
Modified:
4 years ago
Reviewers:
Stephen White
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing paint invalidation when creating canvas 2d context with no alpha BUG=647903 Committed: https://crrev.com/d9b157453d029d17966766dfcf7564fbc03d7c6e Cr-Commit-Position: refs/heads/master@{#437143}

Patch Set 1 #

Total comments: 3

Patch Set 2 : senorblanco feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/canvas/canvas-no-alpha-invalidation.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/canvas/canvas-no-alpha-invalidation-expected.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 4 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Justin Novosad
PTAL
4 years ago (2016-12-07 22:19:08 UTC) #4
Stephen White
LGTM https://codereview.chromium.org/2558973002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-no-alpha-invalidation-expected.html File third_party/WebKit/LayoutTests/fast/canvas/canvas-no-alpha-invalidation-expected.html (right): https://codereview.chromium.org/2558973002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-no-alpha-invalidation-expected.html#newcode3 third_party/WebKit/LayoutTests/fast/canvas/canvas-no-alpha-invalidation-expected.html:3: <canvas id = 'c' width=100 height=100></canvas> Ibid. https://codereview.chromium.org/2558973002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-no-alpha-invalidation.html ...
4 years ago (2016-12-07 22:27:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558973002/20001
4 years ago (2016-12-07 22:50:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 02:12:05 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-08 02:17:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9b157453d029d17966766dfcf7564fbc03d7c6e
Cr-Commit-Position: refs/heads/master@{#437143}

Powered by Google App Engine
This is Rietveld 408576698