chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc - Issue 2558963002: Move shelf item tooltip flag from delegate to item.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

Issue 2558963002: Move shelf item tooltip flag from delegate to item. (Closed)

Patch Set: Cleanup Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/panels/panel_window_resizer_unittest.cc ('K') | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc ('k') | services/ui/public/interfaces/window_manager.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

index 269e94768429d2f7f25161d5ceff7f1289adede3..ed24962591a1e419d919142bbe4450ec92927bb5 100644

--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

@@ -240,10 +240,8 @@ ChromeNativeAppWindowViewsAuraAsh::GetRestoredState() const {

}

bool ChromeNativeAppWindowViewsAuraAsh::IsAlwaysOnTop() const {

- if (app_window()->window_type_is_panel()) {

- return

- ash::wm::GetWindowState(widget()->GetNativeWindow())->panel_attached();

- }

+ if (app_window()->window_type_is_panel())

+ return widget()->GetNativeWindow()->GetProperty(ash::kPanelAttachedKey);

return widget()->IsAlwaysOnTop();

}