Move shelf item tooltip flag from delegate to item.

ash/mus/bridge/wm_window_mus.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/mus/bridge/wm_window_mus.h"
 
 #include "ash/common/shelf/shelf_item_types.h"
 #include "ash/common/wm/container_finder.h"
 #include "ash/common/wm/window_positioning_utils.h"
 #include "ash/common/wm/window_state.h"
@@ skipping 118 matching lines @@
     case WmWindowProperty::SNAP_CHILDREN_TO_PIXEL_BOUNDARY:
       return snap_children_to_pixel_boundary_;
 
     default:
       break;
   }
 
   return WmWindowAura::GetBoolProperty(key);
 }
 
+void WmWindowMus::SetBoolProperty(WmWindowProperty key, bool value) {

[sky, 2016/12/08 00:38:54]

Do we really need the override? Can't we use the implementation in WmWindowAura?

[msw, 2016/12/08 20:31:36]

Would that work? I'm not sure it matters; isn't this code [soon to be] dead?

[sky, 2016/12/08 20:52:42]

It should work, because the property is registered with the PropertyConverter,
right? Maybe I'm missing something?

[msw, 2016/12/08 21:00:21]

I guess I'm not sure what you have in mind here, I thought you meant calling
WmWindowAura::SetBoolProperty here (somehow) or making this function not virtual
and defining WmWindow::SetBoolProperty, but now I think you might mean something
else. What's the problem with leaving this unimplemented? WmWindowMus is going
away as soon as possible after switching mash to aura-mus, right? Sorry if I'm
misunderstanding.

[msw, 2016/12/08 21:18:19]

Done. Thanks for explaining offline that WmWindowMus is a WmWindowAura.

+  NOTIMPLEMENTED();
+}
+
 int WmWindowMus::GetIntProperty(WmWindowProperty key) {
   if (key == WmWindowProperty::SHELF_ITEM_TYPE) {
     if (aura_window()->GetProperty(kShelfItemTypeKey) != TYPE_UNDEFINED)
       return aura_window()->GetProperty(kShelfItemTypeKey);
 
     // Mash provides a default shelf item type for non-ignored windows.
     return GetWindowState()->ignored_by_shelf() ? TYPE_UNDEFINED : TYPE_APP;
   }
 
   return WmWindowAura::GetIntProperty(key);
@@ skipping 116 matching lines @@
 }
 
 void WmWindowMus::AddLimitedPreTargetHandler(ui::EventHandler* handler) {
   DCHECK(WmShellMus::Get()->window_tree_client()->WasCreatedByThisClient(
       aura::WindowMus::Get(aura_window())));
   WmWindowAura::AddLimitedPreTargetHandler(handler);
 }
 
 }  // namespace mus
 }  // namespace ash