Move shelf item tooltip flag from delegate to item.

ash/common/shelf/shelf_window_watcher.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/shelf/shelf_window_watcher.h"
 
 #include <memory>
 #include <utility>
 
 #include "ash/common/shelf/shelf_constants.h"
@@ skipping 20 matching lines @@
     item->status = STATUS_ACTIVE;
   else if (window->GetBoolProperty(WmWindowProperty::DRAW_ATTENTION))
     item->status = STATUS_ATTENTION;
 
   item->app_id = window->GetStringProperty(WmWindowProperty::APP_ID);
 
   // Prefer app icons over window icons, they're typically larger.
   item->image = window->GetAppIcon();
   if (item->image.isNull())
     item->image = window->GetWindowIcon();
+
+  // Do not show tooltips for visible attached app panel windows.
+  item->shows_tooltip =
+      item->type != TYPE_APP_PANEL || !window->IsVisible() ||

[sky, 2016/12/08 00:38:54]

Do we always end up back in this function when the visibility changes?

[msw, 2016/12/08 20:31:36]

This was just working by chance, because minimizing/restoring (or closing)
panels seem to be the only way to change their visibility, and that was also
changing their activation. I wired up WmWindowObserver::OnVisibilityChanged to
this function. It seems like that might add some wasteful no-ops for children
and ancestors of observed user windows, but I don't know how much that really
matters, nor do I have any great ideas to avoid that.

+      !window->GetBoolProperty(WmWindowProperty::PANEL_ATTACHED);
 }
 
 }  // namespace
 
 ShelfWindowWatcher::ContainerWindowObserver::ContainerWindowObserver(
     ShelfWindowWatcher* window_watcher)
     : window_watcher_(window_watcher) {}
 
 ShelfWindowWatcher::ContainerWindowObserver::~ContainerWindowObserver() {}
 
@@ skipping 22 matching lines @@
     : window_watcher_(window_watcher) {}
 
 ShelfWindowWatcher::UserWindowObserver::~UserWindowObserver() {}
 
 void ShelfWindowWatcher::UserWindowObserver::OnWindowPropertyChanged(
     WmWindow* window,
     WmWindowProperty property) {
   if (property == WmWindowProperty::APP_ICON ||
       property == WmWindowProperty::APP_ID ||
       property == WmWindowProperty::DRAW_ATTENTION ||
+      property == WmWindowProperty::PANEL_ATTACHED ||
       property == WmWindowProperty::SHELF_ITEM_TYPE ||
       property == WmWindowProperty::WINDOW_ICON) {
     window_watcher_->OnUserWindowPropertyChanged(window);
   }
 }
 
 void ShelfWindowWatcher::UserWindowObserver::OnWindowDestroying(
     WmWindow* window) {
   window_watcher_->OnUserWindowDestroying(window);
 }
@@ skipping 119 matching lines @@
     observed_container_windows_.Add(panel_container);
 }
 
 void ShelfWindowWatcher::OnDisplayRemoved(const display::Display& old_display) {
 }
 
 void ShelfWindowWatcher::OnDisplayMetricsChanged(const display::Display&,
                                                  uint32_t) {}
 
 }  // namespace ash