Move shelf item tooltip flag from delegate to item.

ash/aura/wm_window_aura.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/aura/wm_window_aura.h"
 
 #include "ash/aura/aura_layout_manager_adapter.h"
 #include "ash/aura/wm_root_window_controller_aura.h"
 #include "ash/aura/wm_shell_aura.h"
 #include "ash/common/ash_constants.h"
@@ skipping 272 matching lines @@
 
 bool WmWindowAura::IsSystemModal() const {
   return window_->GetProperty(aura::client::kModalKey) == ui::MODAL_TYPE_SYSTEM;
 }
 
 bool WmWindowAura::GetBoolProperty(WmWindowProperty key) {
   switch (key) {
     case WmWindowProperty::DRAW_ATTENTION:
       return window_->GetProperty(aura::client::kDrawAttentionKey);
 
+    case WmWindowProperty::PANEL_ATTACHED:
+      return window_->GetProperty(kPanelAttachedKey);
+
     case WmWindowProperty::SNAP_CHILDREN_TO_PIXEL_BOUNDARY:
       return window_->GetProperty(kSnapChildrenToPixelBoundary);
 
     case WmWindowProperty::ALWAYS_ON_TOP:
       return window_->GetProperty(aura::client::kAlwaysOnTopKey);
 
     case WmWindowProperty::EXCLUDE_FROM_MRU:
       return window_->GetProperty(aura::client::kExcludeFromMruKey);
 
     default:
       NOTREACHED();
       break;
   }
 
   return false;
 }
 
+void WmWindowAura::SetBoolProperty(WmWindowProperty key, bool value) {

[sky, 2016/12/08 00:38:54]

Do we really need to set all these properties? I believe when I looked into
these properties I never saw us explicitly setting them via property.

[msw, 2016/12/08 20:31:36]

Reduced to just panel_attached; I was just matching the set from Get.

+  switch (key) {
+    case WmWindowProperty::DRAW_ATTENTION:
+      window_->SetProperty(aura::client::kDrawAttentionKey, value);

[sky, 2016/12/08 00:38:54]

I am tempted to say you should just route through aura::Window now (meaning add
an aura_window() accessor to WmWindow and change code to start using it), but I
really need to think about the best way to unravel all this code.

[msw, 2016/12/08 20:31:36]

We need lots of ash/common cleanup... I'd opt to leave it out of this CL.

+      break;
+    case WmWindowProperty::PANEL_ATTACHED:
+      window_->SetProperty(kPanelAttachedKey, value);
+      break;
+    case WmWindowProperty::SNAP_CHILDREN_TO_PIXEL_BOUNDARY:
+      window_->SetProperty(kSnapChildrenToPixelBoundary, value);
+      break;
+    case WmWindowProperty::ALWAYS_ON_TOP:
+      window_->SetProperty(aura::client::kAlwaysOnTopKey, value);
+      break;
+    case WmWindowProperty::EXCLUDE_FROM_MRU:
+      window_->SetProperty(aura::client::kExcludeFromMruKey, value);
+      break;
+    default:
+      NOTREACHED();
+      break;
+  }
+}
+
 SkColor WmWindowAura::GetColorProperty(WmWindowProperty key) {
   if (key == WmWindowProperty::TOP_VIEW_COLOR)
     return window_->GetProperty(aura::client::kTopViewColor);
 
   NOTREACHED();
   return 0;
 }
 
 void WmWindowAura::SetColorProperty(WmWindowProperty key, SkColor value) {
   if (key == WmWindowProperty::TOP_VIEW_COLOR) {
@@ skipping 561 matching lines @@
   if (key == aura::client::kAlwaysOnTopKey) {
     wm_property = WmWindowProperty::ALWAYS_ON_TOP;
   } else if (key == aura::client::kAppIconKey) {
     wm_property = WmWindowProperty::APP_ICON;
   } else if (key == aura::client::kDrawAttentionKey) {
     wm_property = WmWindowProperty::DRAW_ATTENTION;
   } else if (key == aura::client::kExcludeFromMruKey) {
     wm_property = WmWindowProperty::EXCLUDE_FROM_MRU;
   } else if (key == aura::client::kModalKey) {
     wm_property = WmWindowProperty::MODAL_TYPE;
+  } else if (key == kPanelAttachedKey) {
+    wm_property = WmWindowProperty::PANEL_ATTACHED;
   } else if (key == kShelfIDKey) {
     wm_property = WmWindowProperty::SHELF_ID;
   } else if (key == kShelfItemTypeKey) {
     wm_property = WmWindowProperty::SHELF_ITEM_TYPE;
   } else if (key == kSnapChildrenToPixelBoundary) {
     wm_property = WmWindowProperty::SNAP_CHILDREN_TO_PIXEL_BOUNDARY;
   } else if (key == aura::client::kTopViewInset) {
     wm_property = WmWindowProperty::TOP_VIEW_INSET;
   } else if (key == aura::client::kWindowIconKey) {
     wm_property = WmWindowProperty::WINDOW_ICON;
@@ skipping 45 matching lines @@
     observer.OnTransientChildAdded(this, Get(transient));
 }
 
 void WmWindowAura::OnTransientChildRemoved(aura::Window* window,
                                            aura::Window* transient) {
   for (auto& observer : transient_observers_)
     observer.OnTransientChildRemoved(this, Get(transient));
 }
 
 }  // namespace ash