Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2558943002: Explicitly make BrowserThread::SetDelegate specific to the IO thread. (Closed)

Created:
4 years ago by gab
Modified:
4 years ago
Reviewers:
jam
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly make BrowserThread::SetDelegate specific to the IO thread. The IO thread was already the only user and officially restricting users of this API is required as BrowserThreadDelegates won't be compatible with threads redirected to the TaskScheduler. BUG=653916 Committed: https://crrev.com/90becc91928a53cd44e37dde76e3f29a9507f271 Cr-Commit-Position: refs/heads/master@{#437271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -51 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 6 chunks +30 lines, -35 lines 0 comments Download
M content/public/browser/browser_thread.h View 1 chunk +10 lines, -6 lines 0 comments Download
M content/public/browser/browser_thread_delegate.h View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
gab
@jam PTAL, thanks
4 years ago (2016-12-07 21:46:49 UTC) #3
jam
lgtm
4 years ago (2016-12-08 17:05:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558943002/1
4 years ago (2016-12-08 17:15:17 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 17:20:04 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-08 17:23:00 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90becc91928a53cd44e37dde76e3f29a9507f271
Cr-Commit-Position: refs/heads/master@{#437271}

Powered by Google App Engine
This is Rietveld 408576698