 Chromium Code Reviews
 Chromium Code Reviews Issue 2558933003:
  Cache GL's viewport on the GPU command buffer client side.  (Closed)
    
  
    Issue 2558933003:
  Cache GL's viewport on the GPU command buffer client side.  (Closed) 
  | Index: gpu/command_buffer/client/gles2_implementation_unittest.cc | 
| diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc | 
| index 33b4eda5be9178b189a39205193d8b61d72f7653..ab413c4f3dd9d135911cdff9b96ccb6170d72805 100644 | 
| --- a/gpu/command_buffer/client/gles2_implementation_unittest.cc | 
| +++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc | 
| @@ -404,6 +404,8 @@ class GLES2ImplementationTest : public testing::Test { | 
| static const GLint kMaxVertexAttribs = 8; | 
| static const GLint kMaxVertexTextureImageUnits = 0; | 
| static const GLint kMaxVertexUniformVectors = 128; | 
| + static const GLint kMaxViewportWidth = 8192; | 
| + static const GLint kMaxViewportHeight = 6144; | 
| static const GLint kNumCompressedTextureFormats = 0; | 
| static const GLint kNumShaderBinaryFormats = 0; | 
| static const GLuint kMaxTransformFeedbackSeparateAttribs = 4; | 
| @@ -467,6 +469,8 @@ class GLES2ImplementationTest : public testing::Test { | 
| capabilities.max_vertex_attribs = kMaxVertexAttribs; | 
| capabilities.max_vertex_texture_image_units = kMaxVertexTextureImageUnits; | 
| capabilities.max_vertex_uniform_vectors = kMaxVertexUniformVectors; | 
| + capabilities.max_viewport_width = kMaxViewportWidth; | 
| + capabilities.max_viewport_width = kMaxViewportHeight; | 
| 
Ken Russell (switch to Gerrit)
2016/12/08 01:59:32
max_viewport_height. Ideally that bug would have b
 | 
| capabilities.num_compressed_texture_formats = | 
| kNumCompressedTextureFormats; | 
| capabilities.num_shader_binary_formats = kNumShaderBinaryFormats; |