Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: content/browser/accessibility/accessibility_mode_browsertest.cc

Issue 2558933002: Add more fine-grained accessibility modes. (Closed)
Patch Set: Rename constants Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/accessibility_mode_browsertest.cc
diff --git a/content/browser/accessibility/accessibility_mode_browsertest.cc b/content/browser/accessibility/accessibility_mode_browsertest.cc
index 11e2ad31b6d5b606dd7aed640a2ba2ec796ff850..1d1b20a2eb8712e4d28f3e04bdeab816d636ec69 100644
--- a/content/browser/accessibility/accessibility_mode_browsertest.cc
+++ b/content/browser/accessibility/accessibility_mode_browsertest.cc
@@ -2,7 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "content/browser/accessibility/accessibility_mode_helper.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
@@ -42,17 +41,12 @@ class AccessibilityModeTest : public ContentBrowserTest {
}
}
- AccessibilityMode CorrectedAccessibility(AccessibilityMode mode) {
- return AddAccessibilityModeTo(GetBaseAccessibilityMode(), mode);
- }
-
bool ShouldBeBrowserAccessibilityManager(AccessibilityMode mode) {
- mode = CorrectedAccessibility(mode);
switch (mode) {
case AccessibilityModeOff:
- case AccessibilityModeTreeOnly:
+ case kAccessibilityModeWebContentsOnly:
return false;
- case AccessibilityModeComplete:
+ case kAccessibilityModeComplete:
return true;
default:
NOTREACHED();
@@ -64,61 +58,63 @@ class AccessibilityModeTest : public ContentBrowserTest {
IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AccessibilityModeOff) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
- EXPECT_EQ(CorrectedAccessibility(AccessibilityModeOff),
+ EXPECT_EQ(AccessibilityModeOff,
web_contents()->GetAccessibilityMode());
ExpectBrowserAccessibilityManager(
ShouldBeBrowserAccessibilityManager(AccessibilityModeOff));
}
-IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AccessibilityModeComplete) {
+IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, kAccessibilityModeComplete) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
- ASSERT_EQ(CorrectedAccessibility(AccessibilityModeOff),
+ ASSERT_EQ(AccessibilityModeOff,
web_contents()->GetAccessibilityMode());
AccessibilityNotificationWaiter waiter(shell()->web_contents());
- web_contents()->AddAccessibilityMode(AccessibilityModeComplete);
- EXPECT_EQ(AccessibilityModeComplete, web_contents()->GetAccessibilityMode());
+ web_contents()->AddAccessibilityMode(kAccessibilityModeComplete);
+ EXPECT_EQ(kAccessibilityModeComplete, web_contents()->GetAccessibilityMode());
waiter.WaitForNotification();
ExpectBrowserAccessibilityManager(
- ShouldBeBrowserAccessibilityManager(AccessibilityModeComplete));
+ ShouldBeBrowserAccessibilityManager(kAccessibilityModeComplete));
}
-IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AccessibilityModeTreeOnly) {
+IN_PROC_BROWSER_TEST_F(AccessibilityModeTest,
+ kAccessibilityModeWebContentsOnly) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
- ASSERT_EQ(CorrectedAccessibility(AccessibilityModeOff),
+ ASSERT_EQ(AccessibilityModeOff,
web_contents()->GetAccessibilityMode());
AccessibilityNotificationWaiter waiter(shell()->web_contents());
- web_contents()->AddAccessibilityMode(AccessibilityModeTreeOnly);
- EXPECT_EQ(CorrectedAccessibility(AccessibilityModeTreeOnly),
+ web_contents()->AddAccessibilityMode(kAccessibilityModeWebContentsOnly);
+ EXPECT_EQ(kAccessibilityModeWebContentsOnly,
web_contents()->GetAccessibilityMode());
waiter.WaitForNotification();
- // No BrowserAccessibilityManager expected for AccessibilityModeTreeOnly
+ // No BrowserAccessibilityManager expected for
+ // kAccessibilityModeWebContentsOnly
ExpectBrowserAccessibilityManager(
- ShouldBeBrowserAccessibilityManager(AccessibilityModeTreeOnly));
+ ShouldBeBrowserAccessibilityManager(kAccessibilityModeWebContentsOnly));
}
IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AddingModes) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
AccessibilityNotificationWaiter waiter(shell()->web_contents());
- web_contents()->AddAccessibilityMode(AccessibilityModeTreeOnly);
- EXPECT_EQ(CorrectedAccessibility(AccessibilityModeTreeOnly),
+ web_contents()->AddAccessibilityMode(kAccessibilityModeWebContentsOnly);
+ EXPECT_EQ(kAccessibilityModeWebContentsOnly,
web_contents()->GetAccessibilityMode());
waiter.WaitForNotification();
ExpectBrowserAccessibilityManager(ShouldBeBrowserAccessibilityManager(
- AccessibilityModeTreeOnly),
+ kAccessibilityModeWebContentsOnly),
"Should be no BrowserAccessibilityManager "
- "for AccessibilityModeTreeOnly");
+ "for kAccessibilityModeWebContentsOnly");
AccessibilityNotificationWaiter waiter2(shell()->web_contents());
- web_contents()->AddAccessibilityMode(AccessibilityModeComplete);
- EXPECT_EQ(AccessibilityModeComplete, web_contents()->GetAccessibilityMode());
+ web_contents()->AddAccessibilityMode(kAccessibilityModeComplete);
+ EXPECT_EQ(kAccessibilityModeComplete, web_contents()->GetAccessibilityMode());
waiter2.WaitForNotification();
ExpectBrowserAccessibilityManager(ShouldBeBrowserAccessibilityManager(
- AccessibilityModeComplete),
+ kAccessibilityModeComplete),
"Should be a BrowserAccessibilityManager "
- "for AccessibilityModeComplete");
+ "for kAccessibilityModeComplete");
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698