Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 255893003: Add libpeerconnection pdb to the symbol archive. (Closed)

Created:
6 years, 8 months ago by tommi (sloooow) - chröme
Modified:
6 years, 8 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add libpeerconnection pdb to the symbol archive. BUG=none NOTRY=True R=grt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266356

Patch Set 1 #

Total comments: 2

Patch Set 2 : Alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tommi (sloooow) - chröme
Hey Greg - can you take a look please? I don't think syzygy instruments this ...
6 years, 8 months ago (2014-04-25 16:00:24 UTC) #1
grt (UTC plus 2)
lgtm w/ a sorting nit https://codereview.chromium.org/255893003/diff/1/chrome/tools/build/win/FILES.cfg File chrome/tools/build/win/FILES.cfg (right): https://codereview.chromium.org/255893003/diff/1/chrome/tools/build/win/FILES.cfg#newcode695 chrome/tools/build/win/FILES.cfg:695: { how about moving ...
6 years, 8 months ago (2014-04-25 19:30:17 UTC) #2
tommi (sloooow) - chröme
Alphabetize
6 years, 8 months ago (2014-04-26 07:37:00 UTC) #3
tommi (sloooow) - chröme
https://codereview.chromium.org/255893003/diff/1/chrome/tools/build/win/FILES.cfg File chrome/tools/build/win/FILES.cfg (right): https://codereview.chromium.org/255893003/diff/1/chrome/tools/build/win/FILES.cfg#newcode695 chrome/tools/build/win/FILES.cfg:695: { On 2014/04/25 19:30:18, grt wrote: > how about ...
6 years, 8 months ago (2014-04-26 07:37:22 UTC) #4
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 8 months ago (2014-04-26 07:37:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/255893003/20001
6 years, 8 months ago (2014-04-26 07:37:49 UTC) #6
tommi (sloooow) - chröme
6 years, 8 months ago (2014-04-26 10:23:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r266356 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698