Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: components/variations/net/variations_http_headers.cc

Issue 2558913003: Restrict transmission of external exp ids to signed in users. (Closed)
Patch Set: Address nit. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/net/variations_http_headers.cc
diff --git a/components/variations/net/variations_http_headers.cc b/components/variations/net/variations_http_headers.cc
index 48e84eb190c96f0f8d1ea955ddda215676d9d206..32179745d559cab9380b261a36be6ee8694d9b2e 100644
--- a/components/variations/net/variations_http_headers.cc
+++ b/components/variations/net/variations_http_headers.cc
@@ -44,6 +44,7 @@ const char kClientData[] = "X-Client-Data";
void AppendVariationHeaders(const GURL& url,
bool incognito,
bool uma_enabled,
+ bool is_signed_in,
net::HttpRequestHeaders* headers) {
// Note the criteria for attaching client experiment headers:
// 1. We only transmit to Google owned domains which can evaluate experiments.
@@ -62,7 +63,8 @@ void AppendVariationHeaders(const GURL& url,
headers->SetHeaderIfMissing(kChromeUMAEnabled, "1");
const std::string variation_ids_header =
- VariationsHttpHeaderProvider::GetInstance()->GetClientDataHeader();
+ VariationsHttpHeaderProvider::GetInstance()->GetClientDataHeader(
+ is_signed_in);
if (!variation_ids_header.empty()) {
// Note that prior to M33 this header was named X-Chrome-Variations.
headers->SetHeaderIfMissing(kClientData, variation_ids_header);
« no previous file with comments | « components/variations/net/variations_http_headers.h ('k') | components/variations/variations_associated_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698